Upgrade THREE.JS to 174 #2931
Draft
Upgrade THREE.JS to 174 #2931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for blockbench-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR keeps track of an attempt to upgrade Three.js to the latest version.
Three.js versions have been hit-or-miss in terms of working correctly for Blockbench:
https://discourse.threejs.org/t/updates-to-color-management-in-three-js-r152/50791
This PR upgrades to 173, which fixes the performance issue, but contains the color management issues. It attemps to fix those issues, which works fine for shader materials and cubemaps, but anything using built-in three.js materials is still causing issues.