fix(design): the colophon is centred, and its credits stay on one line - #302
Merged
Conversation
The footer sat left against a page that is centred everywhere else, and it carried a 52ch measure of its own — a reading width on a block that is two one-line credits and a row of links, not reading copy. Every locale broke the share line in half well short of the trimmed edge; the German and French ones looked like a paragraph that had been cut off. The sheet's own max-w-6xl is the only width limit the colophon needs, so the measure is gone and text-balance carries the wrap on a phone, where it does have to break. The link row is centred with the text above it. Regression test in the browser suite, since only a rendered page can say how many lines a paragraph actually took.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The footer sat left against a page that is centred everywhere else, and it carried a
max-w-[52ch]measure of its own — a reading width on a block that is two one-line credits and a row of links, not reading copy. Every locale broke the share line in half well short of the trimmed edge; the German and French ones read like a paragraph that had been cut off.The sheet's own
max-w-6xlis the only width limit the colophon needs, so the measure is gone andtext-balancecarries the wrap at phone widths, where it does have to break. The link row is centred with the text above it.Checked in the browser at 1280 and 1440 px in German and French (the longest locale): all three lines render on one line each. At 390 px the two credits break in balanced pairs and the links wrap onto two centred rows.
Regression test in
e2e/layout.spec.ts— only a rendered page can say how many lines a paragraph actually took. Confirmed it fails against the old markup. Browser baseline 122 → 123; version 7.0.0 → 7.0.1 (patch: visual fix).