Use postman response to validate body and arguments #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we use this adjustment or should we skip this implementation since I'm removing the dependency completely? |
|
With postman we can also test if the request parameters were sent correctly. Is this also possible with your approach? |
|
Yes that is possible as I showed you. We tested the url parameter encoding and the sent body is tested as well. |
|
I suggest to close this PR since the adjustment is not necessary anymore. |
|
@jamitJona can I close this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For the
post,putandpatchtest request the postman response is compared with the contents of the mock body to check if the body was sent correctly.The postman response is also used to check if the arguments of the
getrequest were sent correctly.Solves #55