Skip to content

Comments

feat: initial work on creative mode tab sorting#18

Merged
Jamalam360 merged 2 commits intomainfrom
feat/creative-mode-tabs
Jan 19, 2026
Merged

feat: initial work on creative mode tab sorting#18
Jamalam360 merged 2 commits intomainfrom
feat/creative-mode-tabs

Conversation

@Jamalam360
Copy link
Member

No description provided.

@Jamalam360 Jamalam360 requested a review from Copilot January 19, 2026 12:08
@Jamalam360 Jamalam360 self-assigned this Jan 19, 2026
@Jamalam360 Jamalam360 added the enhancement New feature or request label Jan 19, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds creative mode tab sorting functionality to the mod, allowing items to be sorted by their associated creative mode tabs.

Changes:

  • New CreativeModeTabLookup class that maps items to their creative mode tabs
  • CREATIVE_TAB comparator added to sorting options
  • Command chain extended to support up to 5 sorting comparators

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
CreativeModeTabLookup.java New singleton class that builds and maintains a lookup table mapping items to their creative mode tabs
Comparators.java Adds CREATIVE_TAB comparator that sorts items by creative tab display name, with fallback for items without tabs
UserPreferences.java Adds CREATIVE_TAB enum value to SortingComparator and integrates it into the comparator creation logic
SortItOutCommands.java Extends command chain to support 5 comparators (previously 4) to accommodate the new CREATIVE_TAB option
SortItOut.java Registers lifecycle event to build the creative mode tab lookup when server starts

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Jamalam360 Jamalam360 linked an issue Jan 19, 2026 that may be closed by this pull request
@Jamalam360 Jamalam360 merged commit 9b1c1a0 into main Jan 19, 2026
2 checks passed
@Slackow
Copy link

Slackow commented Jan 23, 2026

From reading the original issue, I think the intended suggestion was to order to items according to their order within the tabs, not just based on the tab. I think that makes the most sense since it's a naturally stable order, and was what I was expecting when using it.

@Jamalam360
Copy link
Member Author

Yes, I haven't added it in the first iteration because I wanted to think more about the implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sorting order

2 participants