-
-
Notifications
You must be signed in to change notification settings - Fork 25
print RPY in --test-connect
#41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR enhances the File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- Consider labeling the printed values (e.g.,
x=... y=... z=... roll=...), so the--test-connectoutput is self-describing and easier to interpret when debugging. - If there is any possibility that
stateobjects might not have roll/pitch/yaw attributes (e.g., older drivers or different devices), it may be safer to guard access withhasattror a try/except to avoid runtime errors during--test-connect.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider labeling the printed values (e.g., `x=... y=... z=... roll=...`), so the `--test-connect` output is self-describing and easier to interpret when debugging.
- If there is any possibility that `state` objects might not have roll/pitch/yaw attributes (e.g., older drivers or different devices), it may be safer to guard access with `hasattr` or a try/except to avoid runtime errors during `--test-connect`.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
I mentioned this change in #40 , I hope it makes testing and debugging better :)
Summary by Sourcery
New Features: