Skip to content

Conversation

@peter-mitrano-ar
Copy link

@peter-mitrano-ar peter-mitrano-ar commented Jan 9, 2026

I mentioned this change in #40 , I hope it makes testing and debugging better :)

Summary by Sourcery

New Features:

  • Expose roll, pitch, and yaw values in the SpaceMouse --test-connect output alongside x, y, and z.

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 9, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR enhances the --test-connect CLI output for SpaceMouse by printing full positional and orientation state (XYZ + roll/pitch/yaw) with fixed decimal formatting, and updating the user-facing status message accordingly.

File-Level Changes

Change Details Files
Expand test-connect CLI output to include roll/pitch/yaw with formatted numeric output.
  • Update the status message to indicate that full state values are being read instead of only XYZ.
  • Change the loop print statement to output x, y, z, roll, pitch, and yaw values in a single formatted line with three decimal places and a separator between position and orientation.
pyspacemouse/pyspacemouse_cli.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider labeling the printed values (e.g., x=... y=... z=... roll=...), so the --test-connect output is self-describing and easier to interpret when debugging.
  • If there is any possibility that state objects might not have roll/pitch/yaw attributes (e.g., older drivers or different devices), it may be safer to guard access with hasattr or a try/except to avoid runtime errors during --test-connect.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider labeling the printed values (e.g., `x=... y=... z=... roll=...`), so the `--test-connect` output is self-describing and easier to interpret when debugging.
- If there is any possibility that `state` objects might not have roll/pitch/yaw attributes (e.g., older drivers or different devices), it may be safer to guard access with `hasattr` or a try/except to avoid runtime errors during `--test-connect`.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant