-
-
Notifications
You must be signed in to change notification settings - Fork 23
Update MkDoxy core to version 2.0 #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request updates the MkDoxy core to version 2.0. It includes changes to the package version, MkDocs dependency, and the removal of the Updated class diagram for setup.pyclassDiagram
class setup.py {
-name: str
-version: str
-description: str
-long_description: str
-long_description_content_type: str
-url: str
-author: str
-author_email: str
-license: str
-classifiers: list
-packages: list
-install_requires: list
-extras_require: dict
-python_requires: str
+readme()
+import_dev_requirements()
}
note for setup.py "Updated version to 2.0.0 and added Python 3.13 to classifiers"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
1950d17
to
02a6d6f
Compare
…ht mode support in mkdocs
02a6d6f
to
e15df3b
Compare
…stom_template_dir type to string
Update to the new MkDoxy config
I have tried this out on my repo (https://github.com/gyselax/gyselalibxx) using my fork EmilyBourne:ebourne-131-bad-anchors-v2 to compare with the docs that we have live that use the equivalent fork for v1: EmilyBourne:ebourne-131-bad-anchors. I see a few differences in the generated xml files:
|
Hi @EmilyBourne , thank you for testing. What do you suggest? Approve your PR connected with So if you have time to help me, I will be happy to accept all your PRs, but let me know what is final and what is still in progress (same for other PRs). Thnaks |
That is one solution. For our repo I am pointing to my fork so there is n rush on my side (although maybe your other users would appreciate bug fixes). I don't really have time to investigate either. I have some of this in my head now so it would make sense to look now, but I still don't have a full grip on how the library handles everything. The I can have a quick look to see if I see anything obvious but if I haven't fixed it by Monday I think you'll be on your own unfortunately. Regarding the other PRs I am happy with the results. The changes seem pretty independent of this PR so I have opened duplicates to update |
Hi, thank you for your time. I will try to fix the save_api option in the evening. |
Good news! Digging through the source I realised that With the correct key the generated files are identical except the hash file 🥳 So I think the only things that actually need fixing are:
|
Update MkDoxy core to version 2.0
TBD
Summary by Sourcery
Update the MkDoxy core to version 2.0, which includes updating the minimum MkDocs version, supported Python versions, and removing IDE configuration files.
Enhancements:
Chores: