feat: add configurable tray icon click actions + double click actions…

[postsolar]

… for all modules

• Add double-click support for all modules via CommonConfig
• Add TrayClickAction enum with built-in and custom command support
• Support placeholders in custom commands: {name}, {title}, {icon}, {address}
• Add reusable connect_pressed_with_double_click() to IronbarGtkExt
• Update documentation for new click action configuration
• Full backward compatibility

Closes #1242

🤖 Generated with Claude Code

[postsolar]

For tray I think ideal would be per-item configuration like

[tray.items.nm-applet]
on_click_left = "do something"

[tray.items.telegram-desktop]
on_click_right = "do something else"

but too complicated + YAGNI.

[postsolar]

There is one limitation currently, for tray there's some GTK spam about some CSS errors when opening certain items' menus now (e.g. nm-applet, but not copyq) - IDK what this is and what to do about it, but it's harmless, doesn't seem to be impacting anything.

[JakeStanger]

Thanks for this, this looks good. A few minor things on first pass.

Are you able to split into two commits please? One for the tray features, and one for the global double-click features.

[postsolar]

@JakeStanger all feedback addressed. For configuring gtk-double-click-time I wasn't able to do it with ~/.config/gtk-4.0/settings.ini (maybe it's issues with my setup, IDK), but I was able to confirm it works via GTK Inspector (I set it there and Ironbar behavior was reflecting this).

I chose to keep the default to be 250ms. I think 200ms is too aggressive, I personally struggle with this 😆

[JakeStanger]

I'm wondering if it might be better to run the single-click action always, which'd avoid the delay. It would potentially be more limited, but it would be more inline with standard double-click behaviour in other applications.

[postsolar]

I think it only works for situations where single-click action is some sort of a light toggle, e.g. opening a menu or a popup, where the second click would just cancel it out and trigger the right action. For anything else I think it would basically render it unusable. My personal use cases are covered either way (I only do "toggles" for now), but it would feel quite weird to have it "broken" by the virtue of always performing single click.

As for other software, I could only think of file managers where double clicks exist at all (open vs select, rename vs select, and in Nemo go a directory up vs unselect). In these cases, the semantics of actions always allow for this, and they don't expose any sort of configuration to this. Could you remind me of other examples?

I also don't really notice any delay with 250ms click interval, feels instant to me.

I wouldn't mind making it optional though. OTOH this could be an unnecessary complexity dump onto people casually reading the config guide — might be moved into something like wiki/Advanced Configuration.md.

[postsolar]

From kitty docs (which offers freely configurable double/triple clicks):

Note that the click and double click events have a delay of click_interval to disambiguate from double and triple presses

So they just accept the delay. You prolly already got it from the code, but just in case note that in our implementation, if user only configured single clicks, and no double clicks, then single clicks happen instantly, there's no delay if we're not even waiting for a successive click.

[JakeStanger]

Sorry for the delay - I think going based on Kitty behaviour makes the most sense, since it's the most applicable/similar scenario.

[JakeStanger]

Two minor bits then we're good to go

[JakeStanger]

There is no need to introduce an additional enum here - we can just create a Gtk variant directly.

Suggested change

	Keyword(DoubleClickTimeKeyword),
	}
	#[derive(Debug, Clone, Deserialize)]
	#[cfg_attr(feature = "extras", derive(schemars::JsonSchema))]
	#[serde(rename_all = "lowercase")]
	pub enum DoubleClickTimeKeyword {
	Gtk,
	}
	Gtk

[postsolar]

I don't think it could work without a custom deserializer (which is a lot of new code). This specifically leads to config parsing failing when the value is set to "gtk", only works with null. Is there something I missed, or should I just keep it the current way?

[JakeStanger]

Try including untagged in the enum serde attr

[postsolar]

fe99eaf is unrelated in terms of scope of the PR, but needed to pass clippy. Let me know if I should revert it 👍