Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable plugin caching #65

Merged
merged 3 commits into from
Mar 2, 2018
Merged

Conversation

castvoid
Copy link
Collaborator

@castvoid castvoid commented Mar 1, 2018

No description provided.

@castvoid castvoid requested a review from RayDurrant March 1, 2018 12:32
@RayDurrant
Copy link
Collaborator

RayDurrant commented Mar 2, 2018

The code itself looks ok. Could you remove the comment "// this can probably be written better but oh well - hj"?

If you do want to write the code better, my suggestion would be to write as such:

if (CACHE_ENABLED) {
    /*do cache stuff*/
}
else {
    console.log("Caching disabled");
}

Copy link
Collaborator

@RayDurrant RayDurrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above comment on code style

@castvoid castvoid dismissed RayDurrant’s stale review March 2, 2018 11:27

improved my code :)

Copy link
Collaborator

@RayDurrant RayDurrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@RayDurrant RayDurrant merged commit 25bf186 into master Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants