forked from Symphonic-Joules/engine
-
Notifications
You must be signed in to change notification settings - Fork 1
Fixes (#6) #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JaclynCodes
wants to merge
91
commits into
JaclynCodes:copilot/sub-pr-9-again
Choose a base branch
from
Symphonic-Joules:main
base: copilot/sub-pr-9-again
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fixes (#6) #8
Changes from 90 commits
Commits
Show all changes
91 commits
Select commit
Hold shift + click to select a range
7ee986f
Workaround for packHalf2x16 precision issues on some Android devices …
mvaligursky 38c05b9
Add frame:ready event to GSplatComponentSystem for video capture work…
mvaligursky f0dd1d6
CameraControls enablePan fix (#8126)
kpal81xd b8648d7
Updated main jsdocs block for GSplatComponent (#8130)
mvaligursky 4ff85c6
Refactor gsplat shader chunks: move helpers and customize to common (…
mvaligursky b695c16
Fix typos in some files (#8131)
Edge-Seven 9a5c2e7
Fix unified gsplat double transformation bug (#8135)
mvaligursky 74c2b85
Optimize BoundingBox.containsPoint performance (#8137)
mvaligursky 87cf3eb
AGENTS.md file automatically used by AI agents (such as Cursor) (#8140)
mvaligursky 9a71ca8
Fix GSplat LOD calculation to use nearest point on bounding box (#8138)
mvaligursky 56d2780
Update Renovate config to lock two dependencies
willeastcott f9c24ee
Lock monaco-editor instead of monaco
willeastcott cbbbaec
Update all npm dependencies (#8143)
renovate[bot] c7a7dde
Migrate config .github/renovate.json (#8144)
renovate[bot] 993e37a
Fix PBO texture uploads by ensuring correct texture binding state (#8…
mvaligursky 81bb3b1
Fix unified gsplat rendering when viewport is resized (#8147)
mvaligursky b7311ce
Gizmo snap state fix (#8151)
kpal81xd 0af6f17
Camera controls fly shift fix (#8152)
kpal81xd 0773aa7
Gizmo mouse button option (#8153)
kpal81xd 6719a6c
Update actions/checkout action to v6 (#8157)
renovate[bot] c367ea7
Picker class can (optional) render depth and provide world space pick…
mvaligursky 69c2bf5
[Fix] UploadStream functionality handles lost context (#8160)
mvaligursky 3dcba66
[Fix] improve error messages for script attribute validation (#8172)
mvaligursky 921fa38
[Fix] Correct transmission attenuation rendering (#8173)
mvaligursky 25156f9
GSplat streaming lod - used memory optimization (#8171)
mvaligursky 65fab7b
Add GSplat to ComponentSystemRegistry (#8174)
mvaligursky 01e9350
Remove unnecessary GLSL transpiler config from examples (#8175)
mvaligursky 6b6c934
Add loadingCount parameter to GSplat frame:ready event (#8178)
mvaligursky 9416692
Fix Screen.priority signed integer overflow (#8180)
mvaligursky 0649cd0
Use ministats to display number of splats in an streaming lod example…
mvaligursky 9a9cede
Fix incorrect time calculation in first two frames (#8185)
mvaligursky 5989f00
Add GSplat flipbook animation script + related functionality + exampl…
mvaligursky 25effe0
Add WebGPU support to instancing-custom example - custom WGSL shader …
mvaligursky 16c7883
[DOCS] clarify Asset.preload behaviour (#8189)
lucaheft c6e7b5c
Branch 2.14
6a3d5b1
WebGPU Compute shader edge detect example (#8192)
mvaligursky 963054f
Update all npm dependencies (#8194)
renovate[bot] d8c745c
Update sinon to latest (#8195)
willeastcott 717d825
Update @webgpu/types dependency to latest (#8196)
willeastcott 0fccb56
Regenerate package-lock.json (#8197)
willeastcott f069ec4
[FIX] Address race condition when loading example code (#8198)
willeastcott 9411b79
Update examples NPM dependencies (#8199)
willeastcott a1ef622
Update Examples Browser to React 19 (#8200)
willeastcott bcac005
Regenerate examples package-lock.json (#8201)
willeastcott d27a89a
Add ESM script for annotations and an example (#8202)
willeastcott ddbc964
feat: removed unused react-es6 (#8208)
kpal81xd 51a9030
Added tracing support to log all assets in the registry (#8209)
mvaligursky 37db127
Improvements and fixes to streaming lod gsplat being destroyed (#8210)
mvaligursky 851696e
Fix examples browser compatibility with React 19 and React Router v7 …
mvaligursky d4c7f38
Fix spherical harmonics not rendering with streaming SOGS (#8215)
mvaligursky a973900
Remove deprecated bloom script from animation examples (#8213)
mvaligursky d3c25b7
Adds a soft limit on total splat count rendered for streaming lod (#8…
mvaligursky 42823e1
Remove old private LOD example now that we have public examples (#8218)
mvaligursky 46d577f
fix: Fix broken BlendTrees example (#8216)
abstrakt8 8c888a3
Add WGSL shader support for annotation hotspots (#8219)
mvaligursky 09beb9b
Fix null values in asset cache for ESM scripts causing error (#8221)
snave333 1188f61
Updated Trees example to supply wgsl chunks (#8223)
mvaligursky 27bb84d
Shader Hatch example has WGSL shader to avoid transpilation from GLSL…
mvaligursky 7280517
Outline renderer WGSL chunk (#8225)
mvaligursky c131b5d
WGSL shader variant for Integer Textures example (#8226)
mvaligursky 7ca7427
[BREAKING] Use linear space for vertex colors in gLTF (#8122)
LeXXik 7f8e7a2
AreaPicker & internal shader properties test example fixes (#8227)
mvaligursky 8593288
Unified GSplat support for rendering to shadow map (#8228)
mvaligursky de1e52d
Updated GsplstShaderEffect script to use simpler material API (#8229)
mvaligursky c7b82eb
Improved splatBudget behaviour to allow both increase and decrease LO…
mvaligursky 0b017e7
Simple gsplat viewer engine example with HDR controls (#8232)
mvaligursky bfcf530
Added bloom and other tweeks to Gsplat viewer example (#8234)
mvaligursky 3d90cff
Moved the splatBudget API to gsplat component (#8231)
mvaligursky f2ffa03
[Fix] Specify anonymous cross origin for gsplat assets to avoid secur…
mvaligursky dc37e4d
Fix uninitialized SplatCenter members in GLSL gsplat shader (#8237)
mvaligursky 8677e2d
Add Gaussian Splat AABB Crop Example with Edge Clipping (#8236)
mvaligursky 64cccd9
Examples that create custom ministats hide the default one (#8239)
mvaligursky d75ea62
Updated Ministats to display additional GPU timing on WebGPU
9f115eb
Merge branch 'main' of https://github.com/playcanvas/engine
e94e1a7
lint
f6d1b64
Updated Ministats with additional timings (#8241)
mvaligursky 6b519ba
Internal cursor file is ignored by git (#8242)
mvaligursky 8bd94ce
Workbuffer for gsplat uniform no longer stores covariance, but direct…
mvaligursky 59fa736
Removed workaround related to workbuffer storing covariants on androi…
mvaligursky fd561dd
Add gsplatModifyVS shader customization chunk for gaussian splats (#8…
mvaligursky 6c3c5a5
Update GitHub Artifact Actions (#8247)
renovate[bot] d410848
[FIX] Fix metalness and roughness handling in UsdzExporter (#8248)
willeastcott cdceba5
[Fix] Return correct typed array from texture.read() on WebGPU platfo…
mvaligursky dbf4e53
[FIX] Notify existing element descendants when a screen is added (#8252)
willeastcott 6b7699d
Add simple render pipeline cache for mipmap renderer (WebGPU) (#8253)
mvaligursky 9fc20f1
Add viewport / scissor support to RenderPassShaderQuad (#8254)
mvaligursky 167faff
Adds a GPU-based radix sort implementation using fragment shaders wit…
mvaligursky ed4fa57
Adds support for specifying a custom entry point function name when c…
mvaligursky ec39d34
Increase quad buffer size for ministats to allow more stats to render…
mvaligursky 3fe7463
NPM Publish (#8261)
kpal81xd cb7a63d
Update examples/src/examples/gaussian-splatting/crop.example.mjs
JaclynCodes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Step name doesn't match the Node version being used. 🫧
The step is named "Setup Node.js 22.x" but configures
node-version: 24.x. This inconsistency appears throughout the workflow (lines 49-53, 69-73, 95-99, 118-122, 138-142). Please update all step names to reference "24.x" for clarity.🔎 Suggested fix for consistent naming
Apply this pattern to all five occurrences in the workflow.
📝 Committable suggestion
🤖 Prompt for AI Agents