location based switching #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wallpaper changes based on geographical location. If set and enabled, wallpapers will change in respect of geoposition. Looks more natural and closer to reality, especially in Northern places like Saint-Petersburg or Helsinki... Also, main script was changed to be more flexible in xfce wallpaper channels querying - now its queried from system rather than hardcoded. The only added dependency - pyethem that exists in every modern python
|
Little errors in day part calculation detected. I'll fix them in next commit plus some comments will be added. |
Wallpaper changes based on geographical location. If set and enabled, wallpapers will change in respect of geoposition. Looks more natural and closer to reality, especially in Northern places like Saint-Petersburg or Helsinki... Also, main script was changed to be more flexible in xfce wallpaper channels querying - now its queried from system rather than hardcoded. The only added dependency - pyethem that exists in every modern python Added necessary comments in change_theme and removed some stdout output in wallpaper.py in thins commit
|
Corrected day part decision part, everything seems to work as expected for now... |
Found a side-effect of moving to subprocess rather than os.system resulting in set_enable failed to xfconf-query did not recreated wallpaper paths for founs channels. This issue is fixed as per now.
If default switch time is selected, then pictures will change at predefined times: 06:00, 08:00, 10:00, 16:00, 18:00, 19:00, 20:00, 21:00 Also, the form has been changed a bit: label for Latitude and Longtitude, 'Default location' was renamed to 'Default switch'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wallpaper changes based on geographical location.
If set and enabled, wallpapers will change in respect of geoposition.
Looks more natural and closer to reality, especially in Northern places
like Saint-Petersburg or Helsinki...
Also, main script was changed to be more flexible in xfce wallpaper
channels querying - now its queried from system rather than hardcoded.
The only added dependency - pyethem that exists in every modern python