-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Fix bulk imports adding entries to navigation history #14575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shubhamk0205
wants to merge
25
commits into
JabRef:main
Choose a base branch
from
shubhamk0205:fix-for-issue-13878-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+31
−4
Open
Changes from 23 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
41c6116
Fix bulk imports adding entries to navigation history
shubhamk0205 e760841
Trigger CI
shubhamk0205 3c5271f
Trigger CI
shubhamk0205 f1d5717
Trigger CI
shubhamk0205 bdb70b9
Suppress navigation history updates for bulk insertions
shubhamk0205 cbd9813
fix formatting issue
shubhamk0205 4be103c
fix formatting
shubhamk0205 4fd6f05
fix formatting
shubhamk0205 b6b2b62
fix formatting
shubhamk0205 08d6bbd
Trigger CI
shubhamk0205 0042466
Trigger CI
shubhamk0205 f43ade9
reverted unrelated formatting changes
shubhamk0205 db97184
fix CI errors
shubhamk0205 e4922b9
fix importHandler
shubhamk0205 3f4cbfb
reverted unrelated changes
shubhamk0205 7612988
reverted unrelated changes
shubhamk0205 a75ba39
fixed
shubhamk0205 db4a930
Refactor navigation suppression to use nesting-aware boolean
shubhamk0205 14faff5
Refactor navigation suppression to use nesting-aware boolean
shubhamk0205 2b3aed4
Fix: Prevent ghost navigation history entries from bulk imports (#13878)
shubhamk0205 efdd797
Fix: Prevent ghost navigation history entries from bulk imports (#13878)
shubhamk0205 8fd45e8
Merge branch 'main' into fix-for-issue-13878-v2
shubhamk0205 6ee1150
Move #13878 entry to Unreleased section
shubhamk0205 23a27e2
update comments
shubhamk0205 eb293dc
Merge remote-tracking branch 'upstream/main' into fix-for-issue-13878-v2
shubhamk0205 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment is confusing - so selection happens in case of both single and multiple entries?
Where is the code for "leaving all entries selected"? Because it will neither trigger the if nor else case.
The side effect of this can be - check if earlier on bulk import all entries were actually selected, because otherwise now if they are not selected, lets say the user wants to remove all the entries imported just after the import action, they will have to manually select the imported entries again first instead of just clicking delete,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You’re right — my bad. I forgot to update the comment. I’ll fix it to accurately describe skipping clearAndSelect() for bulk imports.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i checked this ,on bulk import all the entries were not selected , only the first entry was selected from the bulk import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a final heads up to not use AI to communicate. You will be blacklisted from the project if you don't respect our guidelines on using AI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@subhramit i used ai to refine my speech so i can communicate better , but from going forward i will be writing directly here .