-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Column Check for Bibtex Parser #12949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -101,6 +101,7 @@ public class BibtexParser implements Parser { | |
private Set<BibEntryType> entryTypes; | ||
private boolean eof; | ||
private int line = 1; | ||
private int col = 0; | ||
private ParserResult parserResult; | ||
private final MetaDataParser metaDataParser; | ||
private final Map<String, String> parsedBibdeskGroups; | ||
|
@@ -234,6 +235,10 @@ private ParserResult parseFileContent() throws IOException { | |
break; | ||
} | ||
|
||
if (col > 1) { | ||
continue; | ||
} | ||
Comment on lines
+238
to
+240
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The logic here does not follow the fail-fast principle. It should return early if the condition is not met, rather than using 'continue'. |
||
|
||
skipWhitespace(); | ||
|
||
// Try to read the entry type | ||
|
@@ -627,21 +632,25 @@ private char[] peekTwoCharacters() throws IOException { | |
|
||
private int read() throws IOException { | ||
int character = pushbackReader.read(); | ||
col++; | ||
|
||
if (!isEOFCharacter(character)) { | ||
pureTextFromFile.offerLast((char) character); | ||
} | ||
if (character == '\n') { | ||
line++; | ||
col = 0; | ||
} | ||
return character; | ||
} | ||
|
||
private void unread(int character) throws IOException { | ||
if (character == '\n') { | ||
line--; | ||
col = 0; | ||
} | ||
pushbackReader.unread(character); | ||
col--; | ||
if (pureTextFromFile.getLast() == character) { | ||
pureTextFromFile.pollLast(); | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'col' variable is initialized but not documented in the JavaDoc of methods that use it, such as 'parseFileContent'. JavaDoc should be updated to reflect changes in method parameters or behavior.