Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selectgame UI #8

Merged
merged 17 commits into from
Sep 2, 2024
Merged

Selectgame UI #8

merged 17 commits into from
Sep 2, 2024

Conversation

ebisuG
Copy link
Contributor

@ebisuG ebisuG commented Sep 1, 2024

No description provided.

Copy link

railway-app bot commented Sep 1, 2024

🚅 Previously deployed to Railway in the J-Street project. Environment has been deleted.

@FilippoQuattrocchi
Copy link
Member

On deployment there is an error:
Watchpack Error (watcher): Error: EMFILE: too many open files, watch '/app/frontend'

Can you check why?

Link to railway logs

@FilippoQuattrocchi FilippoQuattrocchi added the enhancement New feature or request label Sep 1, 2024
@ebisuG
Copy link
Contributor Author

ebisuG commented Sep 1, 2024

@FilippoQuattrocchi
I found this solution and added some settings to next.config.mjs file. It looks successfully deployed. Can you check?
phosphor-icons/react#45 (comment)

@@ -4,9 +4,18 @@ import GoogleProvider from "next-auth/providers/google"

let googleClientId = process.env.GOOGLE_CLIENT_ID
let googleClientSecret = process.env.GOOGLE_CLIENT_SECRET
let baseUrl = process.env.FRONT_BASE_URL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the env var for frontend? Can works with a const?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now that isn't necessary. In the future I'd like to redirect to game selection page after successful login.
At the moment we need that kind of variable, I think.
Sorry, I accidentally pushed that change.
@FilippoQuattrocchi

@FilippoQuattrocchi FilippoQuattrocchi merged commit cb51173 into dev Sep 2, 2024
1 check passed
@FilippoQuattrocchi FilippoQuattrocchi deleted the selectgame-ui branch September 2, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants