Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor sunburst #49

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Refactor sunburst #49

wants to merge 8 commits into from

Conversation

vincerubinetti
Copy link
Collaborator

@vincerubinetti vincerubinetti commented Feb 11, 2025

  • match svg font size to document font size
  • refactor using d3 util funcs, significantly reducing LOC and complexity. much less custom math, no more recursion (because d3 tree structure gives nice methods to access what we need), more flexible
  • use different method for vertical centering of text (thanks to safari not supporting dominant-baseline with text-path)
  • update testbed to show more children slices, and sometimes have only 1 root slice (testing full circle, which is edge case with SVG arc commands)
  • update viewbox fit util func to return individual numbers
  • write generalized hook to adapt font size (or any other size) in an svg to the size of something in the document

Copy link

netlify bot commented Feb 11, 2025

Deploy Preview for molevolvr ready!

Name Link
🔨 Latest commit 9e769e8
🔍 Latest deploy log https://app.netlify.com/sites/molevolvr/deploys/67ad740f41f88100087c16c5
😎 Deploy Preview https://deploy-preview-49--molevolvr.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vincerubinetti vincerubinetti requested review from falquaddoomi and removed request for falquaddoomi February 11, 2025 23:32
@vincerubinetti vincerubinetti changed the title Sunburst style tweaks Sunburst tweaks Feb 12, 2025
@vincerubinetti vincerubinetti changed the title Sunburst tweaks Refactor sunburst Feb 13, 2025
@vincerubinetti vincerubinetti requested review from falquaddoomi and removed request for falquaddoomi February 18, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant