Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #16 #17

Merged
merged 1 commit into from
Sep 20, 2024
Merged

fixes #16 #17

merged 1 commit into from
Sep 20, 2024

Conversation

the-mayer
Copy link
Collaborator

Description

The latest version of the phangorn package no longer exports read.aa(), a function MolEvolvR utilized. The functionality of read.aa() has been present in read.phyDat() for some time, using the type = "AA" argument. This PR updates MolEvolvR to use read.phyDat() and fixes #16

What kind of change(s) are included?

  • Feature (adds or updates new capabilities)
  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have searched for existing content to ensure this is not a duplicate.
  • I have performed a self-review of these additions (including spelling, grammar, and related).
  • I have added comments to my code to help provide understanding.
  • I have added a test which covers the code changes found within this PR.
  • I have deleted all non-relevant text in this pull request template.
  • Reviewer assignment: Tag a relevant team member to review and approve the changes.

- read.aa is no longer exported but can be replaced with read.phyDat
- this is in accordance with the latest released version of phangorn
@the-mayer the-mayer added the bug Something isn't working label Sep 19, 2024
@the-mayer the-mayer requested a review from epbrenner September 19, 2024 16:39
@the-mayer the-mayer self-assigned this Sep 19, 2024
@the-mayer the-mayer linked an issue Sep 19, 2024 that may be closed by this pull request
Copy link
Contributor

@epbrenner epbrenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. In reviewing some of the surrounding code, a lot of it is outdated, redundant, and in need of a refactor, but I'm putting that on my to-do list. We should be good to merge as-is since most of that outdated code isn't actively used.

@the-mayer
Copy link
Collaborator Author

Thanks @epbrenner for the review and the additional attention to these functions! Merging for now to get pkgdown builds back up and running 👍

@the-mayer the-mayer merged commit 94369a2 into main Sep 20, 2024
1 check passed
@the-mayer the-mayer deleted the 16-bug-molevolvr-dep-phangornreadaa branch September 20, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞[BUG] MolEvolvR dep: phangorn::read.aa()
2 participants