DiscoDOS 3.0 - Sales, Import, Collection, Massive Refactor #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The sold field will save a date when a record was sold on Discogs (or elsewhere?). - Add it as the schema version 3 - Also fix format of sql_upgrades dict - indentations and so on
defaulting to d_artist, discogs_title.
- Basically a start to replace `dsc search` - but most of all a way fo finally create filtered lists of releases - Super simple query language: field=value - If field= is missing, asssume title= - Simple tabulate table layout - Fixme: All releases is still old "All releases search results table"
`dsc import` is now `dsc import details [-u/-z/...]`, which gives the freedom to further migrate to single `dsc import something` command or leave it as is and only do _really_ new commands as `dsc import ...`
- dsc import release ID -> Import a single release to DiscoBASE. When used with -a, also to Discogs online collection. - dsc import details -> Enrich with --tracks and --brainz stuff, as we had it in the import command before. - Todo: Split out "initial/basic" minimal but whole collection import into separate command.
Add `dsc import basic`, rename other import command defs and improve help in a couple of places.
including removal and stating [deprecated] to AcousticBrainz related things.
and remove unused Sold column for now. Leave a commented out debug print in ´import sales` command.
- Package ctrl - Split into collection, mix, common - Hide non-relevant via __ALL__ - Add some missing docstrings - Sort imports
Patterns: TypeControlCommon, TypeControlCommandline
This one is huge and hopefully without much bugs...
for the --offline option.
and some linting in Config class
leaving a lot of unused imports and commented out stuff for reference purposes. Clean up later!
with actual (now unused) db field.
also required changes in fetchers and getters. - link_to now supports return plain markdown string formatted links, which can be rendered by Textual and Rich. - get_listing/fetch_listing has a tui_view mode. - Split purpose of panels: left sales, right release/video
The --all or --extra option enables a view that is "not combined" and displays extra-rows for each item, no matter if it's in a collection item or a sales item.
Also: - Fix bug Sold -> sold - Save listing ID in coll_d_sales_listing_id on first found collection instance
Set coll_orophaned flag in collection table, when d_coll_instance_id's are not in the Discogs collection anymore.
- Postpone working on this later on. - dsc ls view is just more self-explanatory this way. - "magic" setting collection fields via sales import is kept!!! which potentially outputs log messages that might sound confusing to a user... Live with that for now and move on with v3.0 release.
Ensure it's a number, we can't rely on what type is in config.yaml.
- Comment out functionalities to keep an obvious reference. - Comment out help output suggesting manual sold toggle. - Remove outdated toggle_sold.. method, was unused since a long time. - Fix some behaviour in key_value_search UNION SELECT.
JOJ0
force-pushed
the
sell
branch
6 times, most recently
from
48a399a to
b055903
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Too many details. Put efforts into release notes when done.