-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set python 3.11.6 and corresponding py-numpy for gsi-addon-dev template #920
Set python 3.11.6 and corresponding py-numpy for gsi-addon-dev template #920
Conversation
@climbfuji @DavidHuber-NOAA I'm on break for a while starting tomorrow (Dec 20), so if you can verify this and merge if it looks good, that would be much appreciated. Thanks! |
So the "problem" is that this doesn't build on macOS (at least the slightly older versions). I've spent several days with the spack developers on this and we are nearing a solution. Not really a problem if we don't care for the moment, but needed in the mid-term. I am currently building a 1.6.0 release candidate on Hercules, how about I use this template for creating the gsi-addon-env for testing? |
@climbfuji That works for me. Thank you! I am also building a highly pared down version of it on Hera for a quick round of METplus testing. |
Yesterday after much debugging I was able to build gsi-addon-env with Python 3.11.2 on my new macOS (Sonoma, apple-clang@15, Intel architecture) except the last mile - met and metplus didn't build (but all the Python dependencies did). On my other mac (Monterey, apple-clang@13, Arm architecture), py-numpy built but was unusable, causing many build failures for downstream Python packages. The spack and numpy developers are investigating the underlying issue (they verified there is one). Long story short, maybe macOS is never going to be a place for gsi-addon-env because I don't expect that anyone will try to fix the old met/metplus versions on macOS. But having the Python environment issues sorted out on macOS is necessary for updating Python in general in the near future. |
While Python 3.11.6 installed successfully on Hera, it failed to install met/9.1.3 failing with an obscure error:
The full log file for met is available here: |
Did you use the release/1.6.0 version of spack-stack and spack for that? I was able to install gsi-addon-env successfully using this branch based on the release branches. (on Hercules with GNU and Intel). Maybe spack clean -a and kick off the remaining install? Also wortth checking what is in your ~/.spack folder |
Thanks for the suggestions @climbfuji. No, I did not try out release/1.6.0. I will work with that and clean out my ~/.spack. |
Also, just to make sure, before you run
|
@DavidHuber-NOAA Did that work for you? Are you ok with these changes? I am happy to approve and merge if it works for you. Thanks! |
@climbfuji Sorry for not getting back. Yes, it did work and @malloryprow verified that met worked. Yes, please go ahead and merge. |
Thanks very much! |
* Mandatory updates for release/1.6.0 in .gitmodules, configs/containers/*.yaml, configs/containers/specs/jedi-ci.yaml, doc/source/conf.py * Generate module for qhull * release/1.6.0: change crtm build type to release, remove qhull from module blacklist (#919) * set python 3.11.6 and corresponding py-numpy for gsi-addon-dev template (#920) * Update site config and documentation for Hercules for release/1.6.0 * Update site config and documentation for Nautilus * Update site config for Discover and documentation for Discover and ParallelWorks * Update compiler compatibility in New Site documentation (#929) * Add doc/modulefile_templates/node.js and update site config and documentation for spack-stack-1.6.0 for Narwhal (Intel) and S4 * Update doc/source/PreConfiguredSites.rst for gsi-addon-env on S4 * release/1.6.0 site config & documentation updates for Orion, Derecho, Narwhal/GNU, AWS ParallelCluster, AWS Single-Node AMI Red Hat 8, Casper (#930) * site config and documentation updates for spack-stack-1.6.0: Orion, Derecho, Narwhal/GNU, AWS ParallelCluster, AWS Single-Node AMI Red Hat 8, Casper. *A dd information for a new GNU+OpenMPI environment on Hercules that is available for testing. * Remove libtool form Gaea, Hera and Jet. (#937) * release/1.6.0: last site config/doc updates and spack submodule update (release/1.6.0 --> spack-stack-1.6.0) (#935) * Update documentation for acorn * Update documentation for spack-stack-1.6.0 for Hera, Jet, Gaea C5 * release/1.6.0: fix bug in documentation for Hercules, site config updates/cleanup for ParallelWorks (#943) * Changes for NOAA Azure, remove use of intel/2018 compiler on NOAA platforms * Revert changes that were only needed on the release/1.6.0 branch --------- Co-authored-by: Alex Richert <[email protected]> Co-authored-by: Stephen Herbener <[email protected]> Co-authored-by: RatkoVasic-NOAA <[email protected]> Co-authored-by: Natalie Perlin <[email protected]>
Summary
This PR adds [email protected] to the gsi addon environment template. Note the
::
is needed to override therequire:
settings from common/packages.yaml. I chose 3.11.6 because it's listed as preferred in the recipe, and 1.23.4 build with intel whereas various prior and later versions don't work with intel and/or [email protected]. I suggest putting this is 1.6.0 release so that the gsi addon environment should work right out of the box.Testing
Tested building as unchained environment on Hera.
Applications affected
GSi
Systems affected
all systems where gsi-addon-env will be installed
Dependencies
none
Issue(s) addressed
Addresses #908
Checklist