Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For spack-stack 1.6.0: Update eccodes to 2.32.0, py-eccodes to 1.5.0 #913

Merged

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Dec 19, 2023

Summary

All in the title. Requires new versions of eccodes from PR JCSDA/spack#383.

Testing

  • CI

Applications affected

JEDI applications and containers

Systems affected

All

Dependencies

Issue(s) addressed

Resolves #911

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@climbfuji climbfuji self-assigned this Dec 19, 2023
@climbfuji climbfuji added the INFRA JEDI Infrastructure label Dec 19, 2023
@climbfuji climbfuji marked this pull request as ready for review December 19, 2023 01:39
@climbfuji climbfuji requested a review from srherbener December 19, 2023 15:42
@@ -40,7 +40,7 @@
ecbuild:
version: ['3.7.2']
eccodes:
version: ['2.27.0']
version: ['2.32.0']

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the latest version is 2.33.0
I need to check is this 2.32.0 has the updated tables

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@climbfuji if NOAA and emc need to bless the 2.33.0 we should hold off until we can update to this it contains the new WMO BUFR tables

there is also a 2.32.1 just fyi

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BenjaminRuston Given that we are a solid week past the original code freeze date and that eccodes 2.32.0 is the latest available currently in spack develop, we'll go with this in spack-stack-1.6.0. We can update to 2.33.0 in 1.7.0 or in between.

@climbfuji climbfuji force-pushed the feature/update_eccodes_from_spack_dev branch from a4a1041 to 23da640 Compare December 19, 2023 18:24
@climbfuji climbfuji enabled auto-merge (squash) December 19, 2023 18:32
@climbfuji climbfuji merged commit 14dabad into JCSDA:develop Dec 19, 2023
6 checks passed
@climbfuji climbfuji deleted the feature/update_eccodes_from_spack_dev branch December 19, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INFRA JEDI Infrastructure
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

[INSTALL]: eccodes latest (pull from spack dev) for spack-stack 1.6.0
3 participants