Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crtm & wgrib2 version updates #1487

Conversation

AlexanderRichert-NOAA
Copy link
Collaborator

Summary

This PR updates the wgrib2 version to 2.5.0, and uses [email protected] for Global Workflow, GSI, SRW, and UWM.

Testing

Tested concretization and compiling wgrib2 & [email protected].

Applications affected

Pretty everything EMC...

Systems affected

all

Dependencies

none

Issue(s) addressed

Fixes #1185
Addresses #967

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@climbfuji
Copy link
Collaborator

I created #1486 first - can you consolidate your changes into my PR? We need to fix a compile error for the new wgrib2 on macos in #1486 as well. Thanks!

@AlexanderRichert-NOAA
Copy link
Collaborator Author

Yep will do. I created JCSDA/spack#512, feel free to add any macos/apple clang-related fixes there...

@climbfuji
Copy link
Collaborator

Yep will do. I created JCSDA/spack#512, feel free to add any macos/apple clang-related fixes there...

I am not planning to fix this ... I'll use 3.1.1 on macOS for the release and create an issue in the wgrib2 repository to fix the compile errors for apple-clang ;-)

@AlexanderRichert-NOAA
Copy link
Collaborator Author

I merged these changes into your branch (#1486), everything went in clean.

@climbfuji
Copy link
Collaborator

Thanks for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants