Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MPI wrappers for FMS and MAPL builds to enable apple-clang%15.x builds #1104

Merged
merged 3 commits into from
May 8, 2024

Conversation

srherbener
Copy link
Collaborator

@srherbener srherbener commented May 3, 2024

Summary

This PR is simply for syncing up the spack submodule hash for the spack PR (JCSDA/spack/pull/431) that enables builds of FMS and MAPL using apple-clang%15.x.

Testing

These changes were tested on my Mac using apple-clang%15.0.0 (Xcode 15.1).

Applications affected

FMS and MAPL are impacted. The usage of the MPI wrappers has been removed.

Systems affected

The MPI wrappers were removed unconditionally so these changes can affect the HPC platforms, plus MacOS, using FMS and MAPL.

Dependencies

Issue(s) addressed

Fixes #1083

Checklist

@climbfuji
Copy link
Collaborator

Looks good. Will approve after the spack PR is merged etc.

@srherbener
Copy link
Collaborator Author

Ready for review. spack PR has been merged, and the spack submodule hash is updated here (and the .gitmodules file has been restored).

@climbfuji climbfuji merged commit 8c22669 into JCSDA:develop May 8, 2024
7 checks passed
@climbfuji climbfuji deleted the feature/apple-clang15x-fms-mapl branch May 8, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FMS and MAPL builds fail on MacOS Sonoma 14 when using Xcode 15.1
2 participants