zeroing out some of the stokes intializations and fixing formatting #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…variables), and fixing the stokes output formatting in CRTM_RTSolution_Inspect.
chengdang
reviewed
Mar 17, 2025
| RTV(:)%n_Stokes = Opt%n_Stokes | ||
| RTV_Clear(:)%n_Stokes = Opt%n_Stokes | ||
| ELSE | ||
| RTV(:)%n_Stokes = 0 |
There was a problem hiding this comment.
I think this ELSE statement is unnecessary, because Opt%n_Stokes is by default set as 1 (See CRTM_Options_Define.f90) that Opt%n_Stokes > 0 is always true, unless users accidentally set Opt%n_Stokes <= 0, which is wrong.
I feel this IF statement is here to prevent users from assigning a wrong number to Opt%n_Stokes, and to make sure it is at least set as 1 in CRTM.
A lot of the conditional calculations are based on RTV%n_Stokes, especially IF %n_Stokes == 1, so it should never be set as 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Noticed that CRTM_RTSolution_Inspect was producing garbage for the Stokes parameter outputs, because the output formatting was not properly provided AND there was also some spots where RTSolution%Stokes needed be zeroed (removing the garbage).
May address lingering underflow issues.
Issue(s) addressed
Resolves #<issue_number>