Dev branch #3
Open
Dev branch #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GHeeJeon
commented
Jul 13, 2023
Member
Author
GHeeJeon
left a comment
GHeeJeon
left a comment
There was a problem hiding this comment.
상세한 주석과 분리된 컴포넌트 덕분에 코드를 더 잘 이해할 수 있었습니다!
이 리액트 프로젝트를 배포해보는 건 어떤가요!?
|
|
||
| //List에서 handleClick를 사용하기 때문에 리랜더링발생 --> 성능저하 | ||
| //useCallback() : DiaryData가 변하지 않는다면 함수는 새로 생성되지 않음(새로 생성되지 않으므로 메모리에 새로 할당되지 않고 동일 참조값을 사용) | ||
| const handleClick = useCallback((id) => { |
Member
Author
There was a problem hiding this comment.
함수의 재사용성을 위해 useCallback 을 사용하셨군요!
컴포넌트 최적화에 도움이 되는 방법이라고 생각합니다.
리팩토링 할 때 참고하겠습니다. useCallback ! 기억할게요!
| height: 30px; | ||
| padding:0px; | ||
| } | ||
| .diary-submit{ |
Member
Author
There was a problem hiding this comment.
.diary-input 과 더불어 .diary-submit 은 어디에 쓰이나요?
이미 main 과 동기화된 변동사항인지, 현재 pr에서 찾아봤는데 보이질 않네요ㅠㅠ
|
|
||
| const root = ReactDOM.createRoot(document.getElementById('root')); | ||
| root.render( | ||
| <React.StrictMode> |
Member
Author
There was a problem hiding this comment.
<React.StrictMode> 는 레거시 스트링 ref 사용에 대한 경고 및 안전하지 않은 생명주기 메서드 사용에 대한 경고 등 잠재적인 문제를 감지하는 코드로 알고 있습니다.
<React.StrictMode> 를 사용하지 않는다고 해서 앱이 작동하지 않거나 중대한 문제가 생기는 것은 아니지만, <React.StrictMode> 를 제거하신 이유가 궁금합니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
코드리뷰 시작합니다!