Skip to content

[Shared] Adjust FX_AddPrimitive to take a regular pointer instead of … #1267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025

Conversation

Daggolin
Copy link
Contributor

Adjust FX_AddPrimitive to take a regular pointer instead of a double pointer.

This allows us to get rid of invalid casts. Using gcc 15.1.1 on Arch Linux these casts lead to crashes in release builds due to strict aliasing rules in c++.

Thanks to skull for helping to debug this one.

…a double pointer.

This allows us to get rid of invalid casts. Using gcc 15.1.1 on Arch
Linux these casts lead to crashes in release builds due to strict
aliasing rules in c++.

Thanks to skull for helping to debug this one.
@Daggolin Daggolin requested a review from a team as a code owner May 19, 2025 19:21
@Daggolin Daggolin merged commit 9b944b3 into JACoders:master May 21, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants