Skip to content

Conversation

@lposen
Copy link
Contributor

@lposen lposen commented Nov 18, 2025

🔹 JIRA Ticket(s) if any

✏️ Description

Please provide a brief description of what this pull request does.

lposen and others added 30 commits October 6, 2025 19:10
…sses' into jwt/MOB-10947-task-3-android-retrypolicy-config-at-android-br
…sses' into jwt/MOB-10947-task-3-android-retrypolicy-config-at-android-br
…sses' into jwt/MOB-10947-task-3-android-retrypolicy-config-at-android-br
…sses' into jwt/MOB-10947-task-3-android-retrypolicy-config-at-android-br
…sses' into jwt/MOB-10947-task-3-android-retrypolicy-config-at-android-br
lposen and others added 25 commits October 20, 2025 20:23
…ator

[SDK-136] Add Jwt Generator to Example app
…perty-authtoken-of-undefined

[SDK-151] cannot-read-property-authtoken-of-undefined
…-to-latest

[SDK-181] update ios/android sdk versions
…ality

[SDK-149] add-logout-functionality
@qltysh
Copy link

qltysh bot commented Nov 18, 2025

Diff Coverage: The code coverage on the diff in this pull request is 87.6%.

Total Coverage: This PR will increase coverage by 6.97%.

File Coverage Changes
Path File Coverage Δ Indirect
src/core/classes/Iterable.ts -1.3
src/core/classes/IterableApi.ts 100.0
src/core/classes/IterableAuthManager.ts 100.0
src/core/enums/IterableAuthFailureReason.ts 100.0
src/core/enums/IterableRetryBackoff.ts 100.0
src/core/types/IterableAuthFailure.ts 100.0
src/core/types/IterableRetryPolicy.ts 100.0
src/inbox/classes/IterableInboxDataModel.ts 0.2
src/inbox/components/IterableInboxMessageList.tsx -1.5
🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

This is from Qlty Cloud, the successor to Code Climate Quality. Learn more.

@github-actions
Copy link

Lines Statements Branches Functions
Coverage: 58%
58.36% (328/562) 33.03% (75/227) 56.58% (116/205)

@qltysh
Copy link

qltysh bot commented Nov 18, 2025

8 new issues

Tool Category Rule Count
qlty Structure Function with high complexity (count = 7): generateToken 3
qlty Structure Function with many parameters (count = 4): generateToken 2
qlty Structure Deeply nested control flow (level = 4) 2
qlty Structure Function with many returns (count = 10): IterableAppProvider 1

This is from Qlty Cloud, the successor to Code Climate Quality. Learn more.

*
* @return A JWT string
*/
public static String generateToken(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 2 issues:

1. Function with many parameters (count = 4): generateToken [qlty:function-parameters]


2. Function with high complexity (count = 7): generateToken [qlty:function-complexity]

durationMs: Double,
email: String?,
userId: String?,
promise: Promise
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 5): generateJwtToken [qlty:function-parameters]

UIApplication.shared.registerForRemoteNotifications()
}
}
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with high complexity (count = 6): setupUserNotificationCenter [qlty:function-complexity]

) {
return true;
}
return false;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with high complexity (count = 5): isIterableAuthResponse [qlty:function-complexity]

if ((promiseResult as IterableAuthResponse).successCallback) {
(promiseResult as IterableAuthResponse).successCallback?.();
if (promiseResult.successCallback) {
promiseResult.successCallback?.();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deeply nested control flow (level = 4) [qlty:nested-control-flow]

// We are currently only reporting JWT related errors. In
// the future, we should handle other types of errors as well.
if (promiseResult.failureCallback) {
promiseResult.failureCallback?.();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deeply nested control flow (level = 4) [qlty:nested-control-flow]

@lposen lposen closed this Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants