Skip to content

Fix SSL hostname verification failure in PullNotificationsTask #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mherman22 wants to merge 1 commit into from
Closed

Fix SSL hostname verification failure in PullNotificationsTask #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion ...rs/module/xdssender/api/notificationspullpoint/impl/NotificationsPullPointClientImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,12 @@
import org.w3c.dom.Element;

import ca.uhn.hl7v2.model.Message;
import javax.net.ssl.SSLContext;
import javax.net.ssl.TrustManager;
import javax.net.ssl.X509TrustManager;
import javax.net.ssl.SSLSocketFactory;
import java.security.cert.X509Certificate;

import okhttp3.MediaType;
import okhttp3.OkHttpClient;
import okhttp3.Request;
Expand Down Expand Up @@ -162,7 +168,22 @@ private GetMessagesResponse getResponseHttpClient(GetMessages requestPayload) th
StringResult result = new StringResult();
marshaller.marshal(requestPayload, result);

OkHttpClient client = new OkHttpClient().newBuilder().build();
OkHttpClient.Builder clientBuilder = new OkHttpClient().newBuilder();
if (config.getExportCcdIgnoreCerts()) {
final TrustManager[] trustAllCerts = new TrustManager[]{
new X509TrustManager() {
@Override public void checkClientTrusted(X509Certificate[] chain, String authType) {}
@Override public void checkServerTrusted(X509Certificate[] chain, String authType) {}
@Override public X509Certificate[] getAcceptedIssuers() { return new X509Certificate[]{}; }
}
};
SSLContext sslContext = SSLContext.getInstance("TLS");
sslContext.init(null, trustAllCerts, new java.security.SecureRandom());
SSLSocketFactory sslSocketFactory = sslContext.getSocketFactory();
clientBuilder.sslSocketFactory(sslSocketFactory, (X509TrustManager) trustAllCerts[0]);
clientBuilder.hostnameVerifier((hostname, session) -> true);
}
OkHttpClient client = clientBuilder.build();
MediaType mediaType = MediaType.parse("text/xml; charset=utf-8");
String facilitySiteCode = requestPayload.getOtherAttributes().get(new QName(FACILITY_QNAME));
String sinceAttribute = StringUtils.isNotBlank(lastRequestDate) && isValidISODate(lastRequestDate) ? String.format("since=\"%s\"", lastRequestDate)
Expand Down
Loading