Skip to content

[lab-web-scraping-multipages (01_Billboard)] ignacio.ipynb - #8

Open
ignaciolorenzo wants to merge 1 commit into
Ironhack-Data-0621-Remote:mainfrom
ignaciolorenzo:main
Open

[lab-web-scraping-multipages (01_Billboard)] ignacio.ipynb#8
ignaciolorenzo wants to merge 1 commit into
Ironhack-Data-0621-Remote:mainfrom
ignaciolorenzo:main

Conversation

@ignaciolorenzo

Copy link
Copy Markdown

No description provided.

@ArabellaCM

Copy link
Copy Markdown

Hey Ignacio! I have had a look at your Billboard scraping lab 🎶
Good job - your final dataframe is perfect

Comments:

  • You could make your code a bit simpler by skipping the "songs" variable and just using the "soup" variable when you extract the text
  • When you build the dataframe all your lists are the same length so you don't really need the x variable either

In general - don't forget to add comments #️⃣ #️⃣ They make your code easier to follow for other people or for your future self 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants