[lab-revisiting-machine-learning] Susumu - #8
Open
susumusakamoto wants to merge 1 commit into
Open
Conversation
|
Hi Susumu, I'm taking a look at your Machine Learning Revisited lab where you find which columns have too many null values, drop some columns and clean up the gender column. Overall everything works well but I think you could make a cleaner function to clean the gender column at the end. For example you can already see that there are no null values to fill and you can make an if statement that means you don't have to specify what the "other" values are. def clean(x):
if x.upper().startswith('M') or x.upper().startswith('F'):
return x.upper()[0]
else:
return 'Other' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.