Skip to content

Add component tests for MultiSigWithdrawalPanel covering proposal sta… - #873

Open
samuelfrancis163-eng wants to merge 3 commits into
Iris-IV:mainfrom
samuelfrancis163-eng:test-multisig-withdrawal-panel
Open

Add component tests for MultiSigWithdrawalPanel covering proposal sta…#873
samuelfrancis163-eng wants to merge 3 commits into
Iris-IV:mainfrom
samuelfrancis163-eng:test-multisig-withdrawal-panel

Conversation

@samuelfrancis163-eng

@samuelfrancis163-eng samuelfrancis163-eng commented Jul 30, 2026

Copy link
Copy Markdown

Closes #802

  • Bug fix
  • Feature
  • Chore / maintenance
  • Documentation
  • Test coverage

Contributor Checklist

  • Linked the related issue above.
  • Reviewed CONTRIBUTING.md for branch, commit, and PR title conventions.
  • Confirmed this follows the current Stellar Wave contribution flow, if applicable.
  • Added or updated tests when behavior changed.
  • Updated docs, examples, or translations when needed.

Validation

  • npm run lint
  • npm run format:check
  • npm run typecheck
  • npm test
  • npm run build
  • Not run; reason:

Notes for Reviewers

@drips-wave

drips-wave Bot commented Jul 30, 2026

Copy link
Copy Markdown

@samuelfrancis163-eng Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@sshdopey

sshdopey commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Auto-review failed (API error). Leaving PR for human review.

1 similar comment
@sshdopey

sshdopey commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Auto-review failed (API error). Leaving PR for human review.

@samuelfrancis163-eng
samuelfrancis163-eng force-pushed the test-multisig-withdrawal-panel branch from 0f3ebcc to b967b3c Compare July 30, 2026 10:46
@sshdopey

sshdopey commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Auto-review failed (API error). Leaving PR for human review.

@samuelfrancis163-eng
samuelfrancis163-eng force-pushed the test-multisig-withdrawal-panel branch from b967b3c to d571fde Compare July 30, 2026 10:50
@sshdopey

sshdopey commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Auto-review failed (API error). Leaving PR for human review.

github-advanced-security[bot]
github-advanced-security AI found potential problems Jul 30, 2026
View reviewed changes
Comment thread src/__tests__/integration/CampaignUpdates.test.tsx

const mockGetCampaignUpdates = campaignUpdatesModule.getCampaignUpdates as jest.Mock;
const mockCreateCampaignUpdate = campaignUpdatesModule.createCampaignUpdate as jest.Mock;
const mockVerifyUpdateSignature = campaignUpdatesModule.verifyUpdateSignature as jest.Mock;
@samuelfrancis163-eng
samuelfrancis163-eng force-pushed the test-multisig-withdrawal-panel branch from d571fde to 44e09e3 Compare July 30, 2026 10:52
@sshdopey

sshdopey commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Auto-review failed (API error). Leaving PR for human review.

@samuelfrancis163-eng
samuelfrancis163-eng force-pushed the test-multisig-withdrawal-panel branch from 44e09e3 to 581611a Compare July 30, 2026 10:57
@sshdopey

sshdopey commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Auto-review failed (API error). Leaving PR for human review.

@samuelfrancis163-eng
samuelfrancis163-eng force-pushed the test-multisig-withdrawal-panel branch from 581611a to 41e9d73 Compare July 30, 2026 10:59
@sshdopey

sshdopey commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Auto-review failed (API error). Leaving PR for human review.

@samuelfrancis163-eng
samuelfrancis163-eng force-pushed the test-multisig-withdrawal-panel branch from 41e9d73 to 0e71b6b Compare July 30, 2026 11:01
@sshdopey

sshdopey commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Auto-review failed (API error). Leaving PR for human review.

@samuelfrancis163-eng
samuelfrancis163-eng force-pushed the test-multisig-withdrawal-panel branch from 0e71b6b to 7674912 Compare July 30, 2026 11:04
@sshdopey

sshdopey commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Auto-review failed (API error). Leaving PR for human review.

@samuelfrancis163-eng
samuelfrancis163-eng force-pushed the test-multisig-withdrawal-panel branch from 7674912 to f6226e4 Compare July 30, 2026 11:10
@sshdopey

sshdopey commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Auto-review failed (API error). Leaving PR for human review.

@samuelfrancis163-eng
samuelfrancis163-eng force-pushed the test-multisig-withdrawal-panel branch from f6226e4 to 05c6e86 Compare July 30, 2026 11:12
@sshdopey

sshdopey commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Auto-review failed (API error). Leaving PR for human review.

@sshdopey

sshdopey commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Auto-review failed (API error). Leaving PR for human review.

@sshdopey

sshdopey commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Auto-review failed (API error). Leaving PR for human review.

davidmaronio
davidmaronio requested changes Aug 4, 2026
View reviewed changes

@davidmaronio davidmaronio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding coverage for MultiSigWithdrawalPanel, that component has been untested and #802 asked for exactly this. the intent is right, but the branch needs a substantial cleanup before it is reviewable:

  1. scope: a tests-only PR is currently touching 37 files, including package-lock.json, scripts/bundle-size-baseline.json, messages/en.json, es.json, src/app/api/health/route.ts, many unrelated test files, and e2e specs. please rebase onto latest main and reduce the diff to the new test file (plus any strictly required mock).
  2. test-results.json - a generated test-run artifact is committed; please remove it and consider adding it to .gitignore.
  3. src/tests/components/MultiSigWithdrawalPanel.test.tsx - the repo convention is src/tests/components/, so jest may not even pick this path up depending on the testMatch config; please move it next to the other component tests.
  4. the "Validate branch name" and "Validate commit messages" checks fail and those are real, not the stale-base issue; the branch and commits need to follow the conventions in CONTRIBUTING.md.
  5. the PR is also in merge-conflict state against main, which the rebase in item 1 will resolve.

happy to review the actual test content once the diff is just the test file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidmaronio davidmaronio davidmaronio requested changes
+1 more reviewer
@github-advanced-security github-advanced-security[bot] github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Testing] Add component test for MultiSigWithdrawalPanel proposal states

4 participants

@samuelfrancis163-eng @sshdopey @github-advanced-security @davidmaronio