feat(ui): add campaign transfer ownership UI - #1042
Open
OpensrcLord wants to merge 2 commits into
Open
Conversation
Add a two-step campaign transfer ownership flow on the campaign detail page (initiate + accept via contractClient helpers), wire it through WalletContext, and polish the CauseCard description rendering. Resolves Iris-IV#577
Contributor
|
Auto-review failed (API error). Leaving PR for human review. |
Contributor
Author
|
Split done per your review feedback, @davidmaronio.
Both are ready to review. |
Contributor
|
the transfer panel and contract client work look good and ci is green. two things before merge: please split the walletcontext state/actions refactor (plus the unrelated causecard tests and styling tweaks) into its own pr, this one should stay transfer-only. and in the split itself, the actions usememo only lists connectwithsocial as a dep while also capturing connectwallet and disconnectwallet, which risks stale closures. worth fixing when you extract it. |
Contributor
|
Auto-review failed (API error). Leaving PR for human review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Campaign transfer ownership UI + cause card polish, split out from the original combined PR per review feedback. This is the feature half; the observability security fix (issue #566) lives in its own PR.
Related Issues
Closes #577
Changes
Campaign Transfer UI
src/lib/contractClient.ts— 4 new contract functions:getCampaignTransfer(campaignId)— view function to check pending transferinitiateCampaignTransfer(campaignId, newOwner)— creator starts 2-step transferacceptCampaignTransfer(campaignId)— recipient accepts pending transfercancelCampaignTransfer(campaignId)— creator cancels pending transfersrc/components/CampaignTransferPanel.tsxsrc/app/[locale]/causes/[id]/CauseDetailClient.tsxsrc/components/WalletContext.tsxCause Card Polish
src/components/CauseCard.tsx— constrained description renderingsrc/components/ThirdPartyScripts.tsx— widenedScriptStrategyruntime check commentsrc/__tests__/components/CauseCard.test.tsx— cover description fallback, save button and action failures (56 tests)Verification
main