feat(ui): add campaign impact reporting

[thebabalola]

Closes #672

Summary of Changes

Adds a new Impact tab to the campaign detail page that shows donors the tangible outcomes of their contributions. The tab displays completed milestones with their targets and a summary of total funds raised vs. milestones hit.

What Changed

• New component: src/components/ImpactReport.tsx

  • Reads campaign.milestones[] and filters completed ones (where targetAmount <= amountRaised)
  • Shows stats row: Total Raised (XLM), Milestones Completed, Updates Posted
  • Lists completed milestones with description, target amount, and ✓ checkmark
  • Empty state when no milestones defined yet

• Modified: src/components/CampaignTabs.tsx

  • Added "impact" tab alongside existing "updates" and "comments" tabs
  • Renders ImpactReport when Impact tab is active
  • Uses useTranslations for tab labels

• i18n: Added translations for both English and Spanish

  • messages/en.json: CauseDetail.tabs.impact + ImpactReport namespace
  • messages/es.json: Same keys with Spanish translations

Testing / Local Verification

• npm run lint — passes (only pre-existing warnings in unrelated files)
• npm run format:check — passes
• npm run typecheck — passes (only pre-existing errors in unrelated files)
• npm test -- i18n — 3/3 tests pass (translation parity verified)
• git log upstream/main..HEAD --oneline — clean history, commits from thebabalola

Notes

The build (npm run build) and some CI checks fail due to pre-existing syntax errors in WalletContext.tsx and CauseDetailClient.tsx (unrelated to this PR). These exist on upstream/main and block the build for everyone.

The ImpactReport component is ready for enhancement — future work can parse creator updates for outcome metrics (e.g., "200 families served") and display them as highlights.

[thebabalola]

hey, implemented the campaign impact reporting feature for #672. added an Impact tab that shows completed milestones and funding stats. ready for review — happy to make adjustments if needed!

[sshdopey]

Auto-review failed (API error). Leaving PR for human review.

[davidmaronio]

thanks for this, the impact tab is a nice addition. the tab wiring in CampaignTabs is clean, the component follows the existing zinc/dark styling, and you translated the tab labels and all new strings in both en and es instead of hardcoding them. also good that you localized the amount formatting via formatXlm with the active locale.

on CI: the red checks are not yours. the latest lint/typecheck runs fail with parse errors in src/components/WalletContext.tsx and src/app/[locale]/causes/[id]/CauseDetailClient.tsx, files this PR does not touch, so it is a stale/broken base at merge time. a rebase on current main should clear it. branch name check already passes on the latest run after your rename.

a few asks before merge:

1. src/components/ImpactReport.tsx:36 the "updates posted" stat is hardcoded to "0". showing a permanent zero is misleading on campaigns that do have updates. either pull the real count (the updates section already fetches them) or drop this stat until the data is available.
2. src/components/ImpactReport.tsx:42 stats[2].value === "0" is always true because of the hardcoded value above, so the empty-state condition is effectively just completedMilestones.length === 0. once you fix ask 1 this works, otherwise simplify the condition so the intent is clear.
3. src/components/ImpactReport.tsx:96 using the array index as the react key is fine for a static list, but milestones have a description/target you could key on to be safe if the list ever reorders.
4. messages/fr.json and messages/pt.json (from #1028) will not have the new CauseDetail.tabs and ImpactReport keys, so whichever of these two PRs lands second needs to add the keys to the other locales. worth coordinating with #1028.

[sshdopey]

Auto-review failed (API error). Leaving PR for human review.

[davidmaronio]

the review items are fixed: the hardcoded updates-posted stat is gone and the empty state now shows the noMilestones message, nice. two tiny cleanups: updatesPosted and outcomeHighlights keys in en/es are no longer referenced, and milestone.description as a react key could collide, consider the index. main blocker left is the base: please rebase onto current main and fix the commit-message check, then this is mergeable.

[thebabalola]

hey @davidmaronio, quick update — the three code review items you raised have already been addressed by @Richiey1 in commits 2393f74 and de98c6b: the hardcoded 'updates posted' stat is gone, the empty-state condition is simplified, and milestones now use description-based React keys. the ImpactReport and CampaignTabs changes are clean. the remaining CI failures (lint, typecheck, build) are the same pre-existing parse errors in WalletContext.tsx and CauseDetailClient.tsx that exist on upstream/main — this PR doesn't touch those files. happy to rebase onto latest main if that helps clear the stale checks.

[sshdopey]

Auto-review failed (API error). Leaving PR for human review.

[sshdopey]

Auto-review failed (API error). Leaving PR for human review.

[thebabalola]

hey @davidmaronio, rebased onto current main and addressed the remaining items:

• removed the unused updatesPosted and outcomeHighlights keys from en/es
• switched the milestone list key from description to index to avoid potential collisions
• fixed the stroopsToXlmNumber import (was pointing at formatters, actually lives in stellarAmount)
• updated the i18n test typing so nested translation objects like CauseDetail.tabs compile cleanly

the review feedback from @Richiey1 is already in place (hardcoded stat removed, empty state simplified, description-based keys were there but I’ve switched to index per your note). the merge conflicts in en/es are resolved. the remaining CI failures on this PR are the same pre-existing parse errors in WalletContext.tsx and CauseDetailClient.tsx that exist on upstream/main — this branch doesn’t touch those files. let me know if anything else is needed.

[thebabalola]

@davidmaronio , kindly review