feat(sdk): implement SDK methods for governance and document insurance pool threats - #568
Merged
Levi-Ojukwu merged 3 commits intoJul 25, 2026
Conversation
Resolves Invoice-Liquidity-Network#560 The listProposals contract function accepts status, page, and pageSize parameters for server-side pagination and filtering. Updated the SDK method to pass these parameters to the contract instead of only doing client-side filtering.
Resolves Invoice-Liquidity-Network#561 Added hasVoted method to check if an address has voted on a proposal. Exposes the existing contract function through the SDK for UI use cases where vote status feedback is needed.
Resolves Invoice-Liquidity-Network#562 Added comprehensive threat model section covering insurance pool-specific risks: - Premium Manipulation: Risk of admin-controlled premium rates without bounds - Claim Fraud & Moral Hazard: Potential for collusion between members and payers - Pool Drainage / Insolvency: Risk of insufficient reserves for claims Includes attack scenarios, current mitigations, residual risk assessment, and detailed recommendations for each threat (dynamic premium adjustment, claim prioritization, reserve requirements, stop-loss mechanisms, reinsurance options).
|
@gotethry Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Implemented three issues to enhance governance SDK methods and security documentation.
Issues Resolved
Closes #560
Closes #561
Closes #562
Changes
#560 - Implement SDK method for
getProposalandlistProposalswith filteringUpdated listProposals to pass server-side pagination parameters (status, page, pageSize)
to the contract instead of only doing client-side filtering. This enables efficient
retrieval of proposals with proper pagination.
#561 - Implement SDK method for
hasVotedAdded hasVoted method to check if an address has voted on a proposal. This enables
voting UIs to display vote status feedback to users, improving user experience.
#562 - Update threat-model.md with insurance pool risks
Added comprehensive threat model section covering insurance pool-specific risks:
Each threat includes attack scenarios, current mitigations, residual risk assessment,
and detailed recommendations.