Make the Tx.&& and Tx.|| short-circuit also in Haskell #7432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bezirg
force-pushed
the
bezirg/short-circuit-haskell
branch
from
4c314e2 to
ddb2a4d
Compare
bezirg
force-pushed
the
bezirg/short-circuit-haskell
branch
from
ddb2a4d to
7549152
Compare
Contributor
Author
|
Can somebody explain to me why this change affects the uplc code generation? See the failing tests |
Collaborator
|
It's probably because GHC changing up something because arguments being lazy. I'll take a look today |
Collaborator
|
Okay, none of the tests actually fails, just the golden files need to be updated. Interestingly, this change makes script inline the definitions of equality in multiple places, making it less efficient. I doubt there's anything we can do to actually fix it because at plugin level we don't have enough control |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not affect UPLC code, which should be already short-circuiting. This is about Haskell offchain code that uses the PlutusTx library. The PR provides a simple unit test.