Add CaseApply optimization
#7421
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeungheonOh
force-pushed
the
sho/applyOptimization
branch
from
c8d872c to
47a0318
Compare
SeungheonOh
force-pushed
the
sho/applyOptimization
branch
from
47a0318 to
b8810a2
Compare
Collaborator
Author
budget changesplutus-benchmark/bitwise/test/9.6/8
plutus-benchmark/bitwise/test/9.6/Ed25519.golden.eval
plutus-benchmark/cardano-loans/test/9.6/main.golden.eval
plutus-benchmark/coop/test/9.6/authMpBurning.golden.eval
plutus-benchmark/coop/test/9.6/authMpMinting.golden.eval
plutus-benchmark/coop/test/9.6/certMpBurning.golden.eval
plutus-benchmark/coop/test/9.6/certMpMinting.golden.eval
plutus-benchmark/coop/test/9.6/fsMpBurning.golden.eval
plutus-benchmark/coop/test/9.6/fsMpMinting.golden.eval
plutus-benchmark/coop/test/9.6/mustBurnOwnSingleton.golden.eval
plutus-benchmark/linear-vesting/test/9.6/main.golden.eval
plutus-benchmark/lists/test/Lookup/9.6/match-builtin-list-10.golden.eval
plutus-benchmark/lists/test/Lookup/9.6/match-builtin-list-100.golden.eval
plutus-benchmark/lists/test/Lookup/9.6/match-builtin-list-5.golden.eval
plutus-benchmark/lists/test/Lookup/9.6/match-builtin-list-50.golden.eval
plutus-benchmark/lists/test/Lookup/9.6/match-scott-list-10.golden.eval
plutus-benchmark/lists/test/Lookup/9.6/match-scott-list-100.golden.eval
plutus-benchmark/lists/test/Lookup/9.6/match-scott-list-5.golden.eval
plutus-benchmark/lists/test/Lookup/9.6/match-scott-list-50.golden.eval
plutus-benchmark/lists/test/Sum/9.6/left-fold-built-in.golden.eval
plutus-benchmark/lists/test/Sum/9.6/left-fold-data.golden.eval
plutus-benchmark/lists/test/Sum/9.6/left-fold-scott.golden.eval
plutus-benchmark/lists/test/Sum/9.6/right-fold-built-in.golden.eval
plutus-benchmark/lists/test/Sum/9.6/right-fold-data.golden.eval
plutus-benchmark/lists/test/Sum/9.6/right-fold-scott.golden.eval
plutus-benchmark/nofib/test/9.6/clausify-F5.golden.eval
plutus-benchmark/nofib/test/9.6/knights10-4x4.golden.eval
plutus-benchmark/nofib/test/9.6/queens4-bt.golden.eval
plutus-benchmark/nofib/test/9.6/queens5-fc.golden.eval
plutus-benchmark/script-contexts/test/V1/9.6/checkScriptContext1-20.golden.eval
plutus-benchmark/script-contexts/test/V1/9.6/checkScriptContext1-4.golden.eval
plutus-benchmark/script-contexts/test/V1/9.6/checkScriptContext2-20.golden.eval
plutus-benchmark/script-contexts/test/V1/9.6/checkScriptContext2-4.golden.eval
plutus-benchmark/script-contexts/test/V2/9.6/checkScriptContext1-20.golden.eval
plutus-benchmark/script-contexts/test/V2/9.6/checkScriptContext1-4.golden.eval
plutus-benchmark/script-contexts/test/V2/9.6/checkScriptContext2-20.golden.eval
plutus-benchmark/script-contexts/test/V2/9.6/checkScriptContext2-4.golden.eval
plutus-benchmark/script-contexts/test/V2/9.6/sopFwdStakeTrick.golden.eval
plutus-benchmark/script-contexts/test/V3/9.6/checkScriptContext1-20.golden.eval
plutus-benchmark/script-contexts/test/V3/9.6/checkScriptContext1-4.golden.eval
plutus-benchmark/script-contexts/test/V3/9.6/checkScriptContext2-20.golden.eval
plutus-benchmark/script-contexts/test/V3/9.6/checkScriptContext2-4.golden.eval
plutus-benchmark/script-contexts/test/V3/Data/9.6/purposeIsWellFormed-4.golden.eval
plutus-ledger-api/test-plugin/Spec/Budget/9.6/geq1.golden.eval
plutus-ledger-api/test-plugin/Spec/Budget/9.6/geq2.golden.eval
plutus-ledger-api/test-plugin/Spec/Budget/9.6/geq3.golden.eval
plutus-ledger-api/test-plugin/Spec/Budget/9.6/geq4.golden.eval
plutus-ledger-api/test-plugin/Spec/Budget/9.6/geq5.golden.eval
plutus-ledger-api/test-plugin/Spec/Budget/9.6/gt1.golden.eval
plutus-ledger-api/test-plugin/Spec/Budget/9.6/gt2.golden.eval
plutus-ledger-api/test-plugin/Spec/Budget/9.6/gt3.golden.eval
plutus-ledger-api/test-plugin/Spec/Budget/9.6/gt4.golden.eval
plutus-ledger-api/test-plugin/Spec/Budget/9.6/gt5.golden.eval
plutus-ledger-api/test-plugin/Spec/Data/Budget/9.6/geq1.golden.eval
plutus-ledger-api/test-plugin/Spec/Data/Budget/9.6/geq2.golden.eval
plutus-ledger-api/test-plugin/Spec/Data/Budget/9.6/geq3.golden.eval
plutus-ledger-api/test-plugin/Spec/Data/Budget/9.6/geq4.golden.eval
plutus-ledger-api/test-plugin/Spec/Data/Budget/9.6/geq5.golden.eval
plutus-ledger-api/test-plugin/Spec/Data/Budget/9.6/gt1.golden.eval
plutus-ledger-api/test-plugin/Spec/Data/Budget/9.6/gt2.golden.eval
plutus-ledger-api/test-plugin/Spec/Data/Budget/9.6/gt3.golden.eval
plutus-ledger-api/test-plugin/Spec/Data/Budget/9.6/gt4.golden.eval
plutus-ledger-api/test-plugin/Spec/Data/Budget/9.6/gt5.golden.eval
plutus-ledger-api/test-plugin/Spec/Data/Budget/9.6/mintValueBurned.golden.eval
plutus-ledger-api/test-plugin/Spec/Data/Budget/9.6/mintValueMinted.golden.eval
plutus-tx-plugin/test/AsData/Budget/9.6/destructSum-manual.golden.eval
plutus-tx-plugin/test/AsData/Budget/9.6/destructSum.golden.eval
plutus-tx-plugin/test/AsData/Budget/9.6/recordFields.golden.eval
plutus-tx-plugin/test/Budget/9.6/constAccL.golden.eval
plutus-tx-plugin/test/Budget/9.6/constElL.golden.eval
plutus-tx-plugin/test/Budget/9.6/findIndexCheap.golden.eval
plutus-tx-plugin/test/Budget/9.6/findIndexEmptyList.golden.eval
plutus-tx-plugin/test/Budget/9.6/findIndexExpensive.golden.eval
plutus-tx-plugin/test/Budget/9.6/map1.golden.eval
plutus-tx-plugin/test/Budget/9.6/map2.golden.eval
plutus-tx-plugin/test/Budget/9.6/map3.golden.eval
plutus-tx-plugin/test/Budget/9.6/show.golden.eval
plutus-tx-plugin/test/Budget/9.6/sumL.golden.eval
plutus-tx-plugin/test/Budget/9.6/sumR.golden.eval
plutus-tx-plugin/test/BuiltinList/Budget/9.6/drop.golden.eval
plutus-tx-plugin/test/BuiltinList/Budget/9.6/take.golden.eval
plutus-tx-plugin/test/BuiltinList/Budget/9.6/uniqueElementJust.golden.eval
plutus-tx-plugin/test/CallTrace/9.6/successfullEvaluationYieldsNoTraceLog.golden.eval
|
effectfully
reviewed
Nov 18, 2025
| Constr ann idx (processNestedApp <$> ts) | ||
| processNestedApp (Case ann t bs) = | ||
| Case ann (processNestedApp t) (processNestedApp <$> bs) | ||
| processNestedApp t = t |
Contributor
There was a problem hiding this comment.
Are you intentionally not using the transformOf termSubterms pattern we use in almost every other optimization? I really don't like catch-all clauses like that. We add a new AST node and we won't get any warning here, no indication that this should be updated.
Collaborator
Author
There was a problem hiding this comment.
transformOf is bottom up, so It won't capture all nested applications. I agree with processNestedApp t = t. I'll make it so that there's no wildcard matc
Contributor
There was a problem hiding this comment.
It says "bottom-up" but I think they mean something different, 'cause I wouldn't call that "bottom-up":
transformOf :: ASetter a b a b -> (b -> b) -> a -> b
transformOf l f = go where
go = f . over l goIf I'm wrong and transformOf can't be used here, you get a free pass on calling me an insult of your choice for a year.
Collaborator
Author
There was a problem hiding this comment.
Nope. I'm right.
Consider,
(lam a [[[[a (con integer 1)] (con integer 2)] (con integer 3)] (con integer 4)])
If I use transformOf, it will do it from the inside like so it will yield
(lam
a-21
[
(case (constr 0 (con integer 1) (con integer 2) (con integer 3)) a-21)
(con integer 4)
]
)
whereas if I to recursion myself it will do the correct thing and yield
(lam
a-21
(case
(constr 0 (con integer 1) (con integer 2) (con integer 3) (con integer 4))
a-21
)
)
Collaborator
Author
There was a problem hiding this comment.
I would never insult you <3
plutus-core/untyped-plutus-core/src/UntypedPlutusCore/Transform/CaseApply.hs
Outdated
Show resolved
Hide resolved
| (evalSimplifierT . caseReduce) | ||
| , T.test_scopingGood "case-apply" | ||
| (genTerm @DefaultFun) | ||
| T.BindingRemovalOk |
Contributor
There was a problem hiding this comment.
I think it's BindingRemovalNotOk? Not sure. Does anything break if you make it that?
Collaborator
Author
There was a problem hiding this comment.
also passes with BindingRemovalNotOkay. BindingRemovalNotOk should be correct.
Contributor
|
I don't understand how this is an optimisation. Can you explain the logic behind it? |
Collaborator
Author
|
You can check here: #7410 (comment) Basically, applying arguments using |
SeungheonOh
force-pushed
the
sho/applyOptimization
branch
from
8d79313 to
253835b
Compare
Unisay
reviewed
Nov 21, 2025
| simplifyNTimes (_soMaxSimplifierIterations opts) >=> cseNTimes cseTimes | ||
| simplifyNTimes (_soMaxSimplifierIterations opts) | ||
| >=> cseNTimes cseTimes | ||
| >=> if _soCaseApply opts then caseApply else pure |
Contributor
There was a problem hiding this comment.
its strange irregularity: flag is checked here for caseApply, but not checked for cse or simplifier above 🤷🏼♂️
Collaborator
Author
There was a problem hiding this comment.
Other ones run in a loop while case apply only run once so I didn't wanna make a binding for stuff this simple
Unisay
reviewed
Nov 21, 2025
plutus-core/untyped-plutus-core/src/UntypedPlutusCore/Transform/CaseApply.hs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds "application through case/constr" optimization. Pretty decent free optimizations.
It is also possible to turn programs like
into
But this is only possible when the body of inner lambda doesn't reference variable bounded by all previous lambda abstractions. Maybe this is easier to do on PIR side.