-
Notifications
You must be signed in to change notification settings - Fork 482
fix pragmas, indentation and expose plutus-benchmark-common
#7292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no issue with plutus-benchmark
being exposed publicly as long as folks understand that we may break backwards compatibility at will.
@@ -1,4 +1,4 @@ | |||
{-# LANGUAGE LambdaCase #-} | |||
{-# LANGUAGE DerivingStrategies #-} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's enabled globally in plutus-benchmark.cabal
, so it shouldn't be needed here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@perturbing Did you have some reason for adding that, like you needed it to use a copy of the code outside our repository? I've removed this and another one that don't seem to be needed.
plutus-benchmark-common
There's a question about whether this would mean that we'd have to include @zliu41: what do you think? |
If adding |
Remove unnecessary pragmas.
I often like to depend on this lib outside of plutus to experiements and test how costly things are. Like I did here (note that this depends on a custom fork already exposing this lib).
Can we permanently expose this lib in plutus?