Skip to content

Conversation

perturbing
Copy link
Member

I often like to depend on this lib outside of plutus to experiements and test how costly things are. Like I did here (note that this depends on a custom fork already exposing this lib).

Can we permanently expose this lib in plutus?

@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://IntersectMBO.github.io/plutus/pr-preview/pr-7292/

Built to branch gh-pages at 2025-08-28 21:17 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link
Contributor

@effectfully effectfully left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no issue with plutus-benchmark being exposed publicly as long as folks understand that we may break backwards compatibility at will.

@@ -1,4 +1,4 @@
{-# LANGUAGE LambdaCase #-}
{-# LANGUAGE DerivingStrategies #-}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's enabled globally in plutus-benchmark.cabal, so it shouldn't be needed here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@perturbing Did you have some reason for adding that, like you needed it to use a copy of the code outside our repository? I've removed this and another one that don't seem to be needed.

@SeungheonOh SeungheonOh changed the title fix pragmas, indentation and expose plutus-benchmark fix pragmas, indentation and expose plutus-benchmark-common Aug 27, 2025
@kwxm kwxm requested a review from zliu41 August 28, 2025 13:21
@kwxm
Copy link
Contributor

kwxm commented Aug 28, 2025

There's a question about whether this would mean that we'd have to include plutus-benchmark in the Plutus release process and release it to CHaP. An alternative would be to move the relevant code to plutus-ledger-api (which it depends on anyway, although maybe that's not really the right place for it).

@zliu41: what do you think?

@zliu41
Copy link
Member

zliu41 commented Aug 28, 2025

Can we permanently expose this lib in plutus?

If adding visibility: public is all you need, that's totally fine.

@kwxm kwxm added No Changelog Required Add this to skip the Changelog Check Benchmarks labels Aug 28, 2025
Remove unnecessary pragmas.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Benchmarks No Changelog Required Add this to skip the Changelog Check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants