Skip to content

Conversation

bezirg
Copy link
Contributor

@bezirg bezirg commented Aug 7, 2025

I am developing with -O0 which can cut build times in most cases. This makes our repo buildable with -O0.

Also this patch might help with hls and lsp, not 100% sure.

If you don't likek this patch, I can drop it and only keep it locally.

@bezirg bezirg self-assigned this Aug 7, 2025
@bezirg bezirg requested a review from zliu41 August 7, 2025 12:06
@bezirg bezirg added the No Changelog Required Add this to skip the Changelog Check label Aug 7, 2025
Copy link
Contributor

github-actions bot commented Aug 7, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://IntersectMBO.github.io/plutus/pr-preview/docs/pr-7262/

Built to branch gh-pages at 2025-09-30 17:35 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Copy link
Contributor

github-actions bot commented Aug 11, 2025

Execution Budget Golden Diff

3179337 (master) vs 3b2a51b

output

plutus-benchmark/nofib/test/9.6/knights10-4x4.eval.golden

Metric Old New Δ%
CPU 1_023_470_754 1_028_574_754 +0.50%
Memory 5_395_058 5_426_958 +0.59%
Term Size 1_700 1_726 +1.53%
Flat Size 1_674 1_699 +1.49%

This comment will get updated when changes are made.

@bezirg bezirg requested a review from a team August 11, 2025 13:06
@bezirg bezirg force-pushed the bezirg/noopt-build branch from 27b08da to 3204081 Compare August 12, 2025 13:16
@bezirg bezirg force-pushed the bezirg/noopt-build branch from 3204081 to 3b2a51b Compare August 12, 2025 13:17
@bezirg bezirg enabled auto-merge (squash) August 12, 2025 17:19
@bezirg bezirg requested a review from kwxm August 20, 2025 14:09
@Unisay
Copy link
Contributor

Unisay commented Sep 2, 2025

I don't quite understand:

  • Why couldn't we use -00 before.
  • How commits in this PR solve the problem.

@bezirg
Copy link
Contributor Author

bezirg commented Sep 30, 2025

I don't quite understand:

  • Why couldn't we use -00 before.
  • How commits in this PR solve the problem.

There were some compiler options missing on the cabal file.
And there were some GHC -O1 compiler optimisations that happened to fire and make the examples work (e.g. using haskell's div instead of plutus-prelude divide, etc)

@bezirg
Copy link
Contributor Author

bezirg commented Sep 30, 2025

Can somebody accept this? It is not a major change

@Unisay
Copy link
Contributor

Unisay commented Oct 1, 2025

The build is failing for me (aarch64-darwin) with errors like this one:

[60 of 66] Compiling ShortCircuit.Spec ( test/ShortCircuit/Spec.hs, /Users/yura/Projects/Cardano/plutus/dist-newstyle/build/aarch64-osx/ghc-9.6.7/plutus-tx-plugin-1.54.0.0/t/plutus-tx-plugin-tests/build/plutus-tx-plugin-tests/plutus-tx-plugin-tests-tmp/ShortCircuit/Spec.o )

<no location info>: error:
    GHC Core to PLC plugin: Error: Reference to a name which is not a local, a builtin, or an external INLINABLE function: Variable PlutusTx.Builtins.error
                               No unfolding

Copy link
Contributor

@Unisay Unisay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried cabal clean && cabal build all --ghc-option -O0 and it fails.

@bezirg
Copy link
Contributor Author

bezirg commented Oct 1, 2025

I tried cabal clean && cabal build all --ghc-option -O0 and it fails.

It used to work :(

@bezirg
Copy link
Contributor Author

bezirg commented Oct 1, 2025

Actually I give up on it, the unfoldings are not there with -O0 .

@bezirg bezirg closed this Oct 1, 2025
auto-merge was automatically disabled October 1, 2025 12:18

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No Changelog Required Add this to skip the Changelog Check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants