consensus-testlib: add Test.CsjModel #1466
Open
+2,346
−171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfrisby
requested review from
jasagredo,
amesgen,
fraser-iohk,
dnadales and
geo2a
as code owners
nfrisby
commented
Apr 15, 2025
| import qualified Data.Sequence as Seq | ||
|
|
||
| -- | A non-empty 'Seq' | ||
| newtype NonEmptySeq a = UnsafeNonEmptySeq (Seq a) |
There was a problem hiding this comment.
This type doesn't use AnchoredFragment for two reasons.
-
As a model, I'm trying to keep it as simple as possible: so far, I don't need headers at all. And I can't put points in an
AnchoredFragmentbecause of theHasHeaderconstraint. -
So far, the model deals with chains that reach all the way back to
Origin, not fragments. As long as that's true, it seems misleading to useAnchoredFragment.
There was a problem hiding this comment.
The code no longer reaches all the way back to Genesis. It still doesn't involve headers explicitly, but perhaps AnchoredSeq could still be reused?
nfrisby
force-pushed
the
nfrisby/csj-model
branch
2 times, most recently
from
d0c427c to
d408094
Compare
nfrisby
force-pushed
the
nfrisby/csj-model
branch
5 times, most recently
from
e1444da to
ebd743b
Compare
nfrisby
force-pushed
the
nfrisby/csj-model
branch
2 times, most recently
from
edc4bc0 to
27c8abe
Compare
This commit adds the CSJ model but does not yet use it to test the implementation.
This small alteration accomodate the fact that the ChainSync client cannot necessarily a MsgFindIntersect _immediately_ when the CSJ governor emits it.
Payloads and connecting peers forced me ot figure out how to not always persist chains all the way back to Origin. Which forced me to realize and handle some weird corner cases. I'm optimistic, but I do expect friction once this is finally connected to the actual tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A single commit, and essentially a single file.
While this is being reviewed, I'll see if it's easy to integrate into the existing tests.
This PR model is the result of troubleshooting some test failures. I found a minor non-optimality in CSJ (recall that CSJ is fundamentally an optimization), and with the non-centralized definition of the existing CSJ implementation it was challenging for me to establish confidence that there weren't similar issues. I developed this centralized model for more legibility/clarity, and I intend for it to be used at least to test the non-centralized CSJ implementation.