-
Notifications
You must be signed in to change notification settings - Fork 26
KES Agent Connectivity #1402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
tdammers
wants to merge
6
commits into
main
Choose a base branch
from
tdammers/kes-agent-connectivity
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
KES Agent Connectivity #1402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasagredo
reviewed
Feb 21, 2025
...nsus-protocol/src/ouroboros-consensus-protocol/Ouroboros/Consensus/Protocol/Ledger/HotKey.hs
Outdated
Show resolved
Hide resolved
@@ -262,20 +265,38 @@ data PraosCanBeLeader c = PraosCanBeLeader | |||
|
|||
data PraosCredentialsSource c | |||
= PraosCredentialsUnsound (OCert.OCert c) (KES.UnsoundPureSignKeyKES (KES c)) | |||
| PraosCredentialsAgent FilePath |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure if this one should use FsPath instead? cc @jorisdral
c418528
to
42ed7a9
Compare
42ed7a9
to
d2365a8
Compare
The use of
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds KES Agent connectivity to consensus.
To use a KES Agent to source KES SignKeys and OpCerts, the
praosCredentialsSource
in thePraosCanBeLeader
data structure can now be pointed to a domain socket address where it will look for a KES Agent.Also covers #1077.