Skip to content

Drop support for ghc-8.10 #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
Merged

Drop support for ghc-8.10 #692

merged 1 commit into from
Apr 28, 2025

Conversation

jorisdral
Copy link
Collaborator

@jorisdral jorisdral commented Apr 22, 2025

Recently, cardano-node releases have started using ghc-9.6 instead of ghc-8.10. Dropping support for ghc-8.10 in lsm-tree makes our lives a bit easier, because we can use less conditional compilation in our codebase. We'll now support versions ghc-9.2 and up, because we weren't explicitly supporting ghc-9.0 anyway

@wenkokke
Copy link
Collaborator

If it's all there, shouldn't we just do a first release with support for 8.10 and drop it in the second?

@jorisdral
Copy link
Collaborator Author

If it's all there, shouldn't we just do a first release with support for 8.10 and drop it in the second?

I don't think it's very useful to do so. I can understand it from the point of view that there is at least some released version that supports ghc-8.10 for users that want it, but we won't commit to supporting it into the future. Not supporting it from the get-go is in the end more useful for us as developers (no future support, no backporting, less maintenance, no users asking for backports/support). Morever, users that really want to use ghc-8.10 wouldn't be able to meaningfully upgrade their dependency on lsm-tree anyway if we drop it immediately in the next release

Copy link
Collaborator

@jeltsch jeltsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me. Just one comment further below and the following two recommendations:

@jorisdral jorisdral force-pushed the jdral/drop-ghc-8.10 branch from 97f498a to 1494fbd Compare April 25, 2025 09:32
Copy link
Collaborator

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jorisdral jorisdral added this pull request to the merge queue Apr 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 28, 2025
@jorisdral jorisdral force-pushed the jdral/drop-ghc-8.10 branch from 1494fbd to 3240823 Compare April 28, 2025 09:02
@jorisdral jorisdral enabled auto-merge April 28, 2025 09:02
@jorisdral jorisdral added this pull request to the merge queue Apr 28, 2025
Merged via the queue into main with commit 07454c6 Apr 28, 2025
28 checks passed
@jorisdral jorisdral deleted the jdral/drop-ghc-8.10 branch April 28, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants