-
Notifications
You must be signed in to change notification settings - Fork 7
Drop support for ghc-8.10
#692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If it's all there, shouldn't we just do a first release with support for 8.10 and drop it in the second? |
I don't think it's very useful to do so. I can understand it from the point of view that there is at least some released version that supports |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good to me. Just one comment further below and the following two recommendations:
- The following code should be removed:
lsm-tree/cabal.project.release
Lines 25 to 29 in 97f498a
-- TODO: fix assembly error in text-2.1.2 if (impl(ghc < 9.0) && os(windows)) package text flags: -simdutf - In the following code, the lower bound for the
base
version should be changed to4.16
:lsm-tree/scripts/generate-readme.hs
Line 4 in 97f498a
, base >=4.12
97f498a
to
1494fbd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
1494fbd
to
3240823
Compare
Recently,
cardano-node
releases have started usingghc-9.6
instead ofghc-8.10
. Dropping support forghc-8.10
inlsm-tree
makes our lives a bit easier, because we can use less conditional compilation in our codebase. We'll now support versionsghc-9.2
and up, because we weren't explicitly supportingghc-9.0
anyway