Skip to content

Conversation

@solidsnakedev
Copy link
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings November 28, 2025 02:21
Copilot finished reviewing on behalf of solidsnakedev November 28, 2025 02:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the evolution-devnet module by decomposing the monolithic Devnet.ts file into separate, focused modules with clearer separation of concerns. The refactoring also improves test cluster naming conventions to be more descriptive and consistent.

Key changes:

  • Split Devnet.ts into five specialized modules: Cluster.ts, Container.ts, Config.ts, Genesis.ts, and Images.ts
  • Renamed DevnetDefault.ts to Config.ts and updated all error types to match their respective modules
  • Updated test cluster names across all test files to follow a consistent "test-" naming pattern

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/evolution-devnet/src/index.ts Updated exports to expose new module structure (Cluster, Container, Config, Genesis, Images) instead of monolithic Devnet
packages/evolution-devnet/src/Images.ts New module containing Docker image management utilities (pull, availability checks)
packages/evolution-devnet/src/Genesis.ts Extracted genesis UTxO calculation and querying logic into dedicated module
packages/evolution-devnet/src/Container.ts Extracted container lifecycle operations (start, stop, remove, exec) and creation functions
packages/evolution-devnet/src/Config.ts Renamed from DevnetDefault.ts, contains all configuration types and default values
packages/evolution-devnet/src/Cluster.ts Extracted cluster-level orchestration logic for managing multi-container devnet setups
packages/evolution-devnet/src/Devnet.ts Removed - functionality split across new modules
packages/evolution-devnet/test/TxBuilder.Scripts.test.ts Updated imports to use Cluster module and improved cluster naming
packages/evolution-devnet/test/Devnet.integration.test.ts Updated imports to use Cluster and Container modules with improved test cluster names
packages/evolution-devnet/test/Devnet.Genesis.test.ts Updated imports to use Cluster, Config, and Genesis modules with improved naming
packages/evolution-devnet/test/Client.Devnet.test.ts Updated imports to use Cluster, Config, and Genesis modules with improved naming

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +76 to +80
new GenesisError({
reason: "address_conversion_failed",
message: `Failed to convert genesis address hex to bech32: ${addressHex}`,
cause: e
})
Copy link

Copilot AI Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error reason "container_inspection_failed" is used for address conversion failures in Genesis.ts. This reason should be more specific like "address_conversion_failed" to accurately describe the error.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants