Skip to content

Conversation

@tzchenxixi
Copy link
Contributor

@tzchenxixi tzchenxixi commented Sep 1, 2025

Description

fix comment in cardano-submit-api/README.md

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-9.6 and ghc-9.12
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@tzchenxixi tzchenxixi requested a review from a team as a code owner September 1, 2025 17:09
@carbolymer
Copy link
Contributor

@tzchenxixi could you sign your commit and push it again?

@tzchenxixi
Copy link
Contributor Author

@tzchenxixi could you sign your commit and push it again?

Of course. Signed. Please review again.

@carbolymer carbolymer enabled auto-merge September 2, 2025 12:29
@github-actions
Copy link

This PR is stale because it has been open 45 days with no activity.

auto-merge was automatically disabled November 6, 2025 08:30

Head branch was pushed to by a user without write access

@tzchenxixi
Copy link
Contributor Author

@carbolymer I have rebased the code and signed it. Please review again. Thanks!

@carbolymer carbolymer enabled auto-merge November 7, 2025 10:35
@carbolymer carbolymer disabled auto-merge November 17, 2025 07:06
@carbolymer carbolymer enabled auto-merge November 17, 2025 07:06
@carbolymer carbolymer added this pull request to the merge queue Nov 17, 2025
Merged via the queue into IntersectMBO:master with commit aed121f Nov 17, 2025
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants