Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up no ledger migration #1964

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Speed up no ledger migration #1964

wants to merge 1 commit into from

Conversation

Saghen
Copy link

@Saghen Saghen commented Mar 31, 2025 •
edited
Loading

Description

This avoids updating every row in the redeemer table when migrating to a no ledger schema, which speeds up this phase of the startup from 7m 15s to 15s in our case.

Checklist

  • Commit sequence broadly makes sense
  • Commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the changelog
  • Code is formatted with fourmolu on version 0.10.1.0 (which can be run with scripts/fourmolize.sh)
  • Self-reviewed the diff

Migrations

  • The pr causes a breaking change of type a,b or c
  • If there is a breaking change, the pr includes a database migration and/or a fix process for old values, so that upgrade is possible
  • Resyncing and running the migrations provided will result in the same database semantically

@Saghen
Set redeemer fee to null if it is not null
601551b 
Drastically speeds up the no ledger migration
@Saghen Saghen requested a review from a team as a code owner March 31, 2025 17:45
@Saghen Saghen changed the title Set redeemer fee to null if it is not null Speed up no ledger migration Mar 31, 2025
Cmdv
Cmdv approved these changes Apr 1, 2025
View reviewed changes
Copy link
Contributor

@Cmdv Cmdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution this look like a great improvement :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cmdv Cmdv Cmdv approved these changes

@kderme kderme kderme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Saghen @Cmdv @kderme