Skip to content

Conversation

@palas
Copy link
Contributor

@palas palas commented Sep 22, 2025

Changelog

- description: |
    Modified stake-address-info to output pool ID and DRep ID in both hex and bech32 formats
  type:
  - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way

Context

This addresses this issue: #897

How to trust this PR

This is how I tested it in preview:

$ cabal run cardano-cli -- query stake-address-info --address stake_test1updr3r8ru63np2eh4dkumuelp9w6p4l58z8upxj7z5d65qcsnxl97
[
    {
        "address": "stake_test1updr3r8ru63np2eh4dkumuelp9w6p4l58z8upxj7z5d65qcsnxl97",
        "govActionDeposits": {},
        "rewardAccountBalance": 0,
        "stakeDelegation": null,
        "stakeRegistrationDeposit": 2000000,
        "voteDelegation": {
            "keyHashBech32": "drep1yg74fedj67jplvxqqth5lg5ytxjrx8a4ljtzkaarhgcfy0gl7n0hl",
            "keyHashHex": "8200581c3d54e5b2d7a41fb0c002ef4fa28459a4331fb5fc962b77a3ba30923d"
        }
    }
]
$ cabal run cardano-cli -- query stake-address-info --address stake_test1uzzx65ylw8yrkeusmfwa6exesgpzlw74630cxusgq3jn9jqrgsrjc
[
    {
        "address": "stake_test1uzzx65ylw8yrkeusmfwa6exesgpzlw74630cxusgq3jn9jqrgsrjc",
        "govActionDeposits": {},
        "rewardAccountBalance": 150793503137,
        "stakeDelegation": {
            "stakePoolBech32": "pool1zyvx690fps6a9m3m89q6fwcfgd8jyupzgv8wrfpvd0fm5cyzxd0",
            "stakePoolHex": "11186d15e90c35d2ee3b3941a4bb09434f227022430ee1a42c6bd3ba"
        },
        "stakeRegistrationDeposit": 2000000,
        "voteDelegation": null
    }
]

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm leaving approval to @carloslodelar .
@carloslodelar should we print CIP-129 hash for DRep credential additionally?

@palas palas force-pushed the hex-and-bech32-for-pool-id-and-drep-id-in-stake-address-info branch from 70282a1 to 1a6d7a0 Compare September 23, 2025 15:39
@palas palas force-pushed the hex-and-bech32-for-pool-id-and-drep-id-in-stake-address-info branch from c645477 to b4e2da4 Compare October 6, 2025 18:28
@palas palas enabled auto-merge October 6, 2025 18:31
@palas palas added this pull request to the merge queue Oct 6, 2025
Merged via the queue into master with commit f0ca866 Oct 6, 2025
25 checks passed
@palas palas deleted the hex-and-bech32-for-pool-id-and-drep-id-in-stake-address-info branch October 6, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] - stake-address-info to output pool ID and DRep ID in both hex and bech32 formats

4 participants