Delete watchdogProp function

[newhoggy]

Changelog

- description: |
    Delete `watchdogProp` function
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

watchdogProp can be deleted because we are now using a new version of hedgehog-extras that fixes a hanging bug in moduleWorkspace. After fixing this bug, tests do not hang anymore so we do not need watchdogProp to interrupt the hanging test.

The PR that fixed moduleWorkspace is here: input-output-hk/hedgehog-extras#91

The reason the old version of moduleWorkspace hangs is not fully known, however it uses a combination of ResourceT and recovering retryPolicy, which causes the hang.

Aside from the fact that this combination hangs, it is problematic to use ResourceT when the intention is to cleanup resources in a timely manner. The scope of ResourceT is runResourceT which is outside the call to moduleWorkspace. This means that when moduleWorkspace returns, there is no guarantee that the module directory is cleaned up as it is supposed to.

In order to ensure timely cleanup of resources, the bracket family of functions should be used instead.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

• Commit sequence broadly makes sense and commits have useful messages
• New tests are added if needed and existing tests are updated. See Running tests for more details
• Self-reviewed the diff

[Jimbo4350]

Can you add an explanation in the description as to why we can delete watchdogProp?

[carbolymer]

#1225 (review)

[github-actions]

This PR is stale because it has been open 45 days with no activity.

[github-actions]

This issue was closed because it has been stalled for 60 days with no activity.