Skip to content

Use experimental Era type in governance actions #1158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Use experimental Era type in governance actions #1158

wants to merge 2 commits into from

Conversation

palas
Copy link
Contributor

@palas palas commented Apr 30, 2025 •
edited
Loading

Changelog

- description: |
    Use experimental `Era` type in `update-committee` command
  type:
  - refactoring

Context

We are migrating to the new Era type to simplify implementation, since we are no longer supporting old eras.

Based on this cardano-api branch: https://github.com/IntersectMBO/cardano-api/tree/use-experimental-era

How to trust this PR

Ensure it is a refactoring and the code style is good

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas self-assigned this Apr 30, 2025
@palas palas changed the title Use experimental Era type in update-committee Use experimental Era type in governance actions Apr 30, 2025
@palas palas linked an issue May 5, 2025 that may be closed by this pull request
Propagate Era era type through cardano-cli #1155
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350 Jimbo4350 will be requested when the pull request is marked ready for review Jimbo4350 is a code owner

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy will be requested when the pull request is marked ready for review newhoggy is a code owner

@carbolymer carbolymer Awaiting requested review from carbolymer carbolymer will be requested when the pull request is marked ready for review carbolymer is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond will be requested when the pull request is marked ready for review kevinhammond is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler will be requested when the pull request is marked ready for review disassembler is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@palas palas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Propagate Era era type through cardano-cli
1 participant
@palas