[Refactor] Rename intra_layer_micro_batch to packed_samples_per_forward and add domino_forward flag #1123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HAOCHENYE
force-pushed
the
yehc/rename-intralayer
branch
from
1690940 to
1409594
Compare
…rd and add domino_forward flag - Rename intra_layer_micro_batch parameter to packed_samples_per_forward across all files - Add domino_forward boolean flag for controlling forward mode - Update test scripts to use new parameter names - Add packing support for sequence contexts and loss contexts - Update CELossContext to CELossConfig in test scripts
HAOCHENYE
force-pushed
the
yehc/rename-intralayer
branch
2 times, most recently
from
bda4536 to
ad6b6e0
Compare
jayhenry
reviewed
Sep 29, 2025
| profile_time: bool = True | ||
| profile_memory: bool = False | ||
| intra_layer_micro_batch: int = 1 | ||
| packed_samples_per_forward: int = 1 |
There was a problem hiding this comment.
可以命名为 micro_batch_size ，跟业界叫法一致，即有 global_batch_size = micro_batch_size x micro_batch_num(grad_accumulate_num) x dp_size 。
原有代码中的 micro_batch_size 可以改名为 batch_size_per_gpu（或 batch_size_per_rank），即有 batch_size_per_gpu = micro_batch_size x micro_batch_num
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.