-
Notifications
You must be signed in to change notification settings - Fork 372
fix ratio #1108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hhaAndroid
wants to merge
23
commits into
InternLM:main
Choose a base branch
from
hhaAndroid:fix_ratio
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix ratio #1108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RangiLyu
reviewed
Sep 18, 2025
logits = F.linear(hidden_states, w, b) | ||
return None, logits | ||
# Note: the loss calculation will convert logits to float32, so for alignment, | ||
# we also need to convert it to float32 here to prevent the ratio from being 1 during rl training |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
# we also need to convert it to float32 here to prevent the ratio from being 1 during rl training | |
# we also need to convert it to float32 to prevent the ratio from not being equal to 1 during on-policy rl training |
Due to the lack of use of chunk forward when computing old_logprobs, it may cause OOM (Out of Memory). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the loss calculation will convert logits to float32, so for alignment, we also need to convert it to float32 here to prevent the ratio from being 1 during rl training