Hack for runtime loading of WAV files#2760
Open
TwelveEyes wants to merge 1 commit intoInterkarma:masterfrom
Open
Hack for runtime loading of WAV files#2760TwelveEyes wants to merge 1 commit intoInterkarma:masterfrom
TwelveEyes wants to merge 1 commit intoInterkarma:masterfrom
Conversation
It's broken on all platforms
TwelveEyes
force-pushed
the
runtime-wav-loading-hack-windows
branch
from
1241c26 to
bb23612
Compare
TwelveEyes
changed the title
Collaborator
|
I wonder if it has any impact on caching, are effects eventually loaded in game memory, or are they reread from file cache every time. It probably has a small impact, but still. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loading loose WAV audio clip files is completely broken. On current Unity version (
2019.4) it just falls back to the default DF audio files (presumably because the returned AudioClip is null), but on Unity2022.3it fails to fall back (presumably because the returned AudioClip is not null, just empty) so there is no sound at all. Loading of loose OGG music files works just fine though.I don't know why, but setting WAV files to load streamed fixes this issue. 🤷