Skip to content

Add Hermitian FFT to scipy interface #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add Hermitian FFT to scipy interface #161

wants to merge 4 commits into from

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Apr 17, 2025

Add Hermitian FFT to scipy interface

@vtavana vtavana self-assigned this Apr 17, 2025
@vtavana vtavana marked this pull request as ready for review April 18, 2025 00:03
@Copilot Copilot AI review requested due to automatic review settings April 18, 2025 00:03
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Hermitian FFT functions to the Scipy interface in mkl_fft. Key changes include:

  • Adding implementations for the Hermitian FFT functions (hfft, ihfft, hfft2, ihfft2, hfftn, ihfftn) in the core interface.
  • Updating test files (test_multithreading.py and test_basic.py) to incorporate and validate the new Hermitian FFT functionality.
  • Modifying function signatures (making the plan parameter keyword‐only) and updating helper modules (_scipy_fft.py, _numpy_fft.py, _fft_utils.py) to support the new features.

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
mkl_fft/tests/third_party/scipy/test_multithreading.py Added Hermitian FFT functions in the multithreading tests.
mkl_fft/tests/third_party/scipy/test_basic.py Unskipped and updated tests to include Hermitian FFT functions and updated expected behaviors.
mkl_fft/_scipy_fft.py Extended the Scipy FFT interface by adding new Hermitian FFT functions and altering function signatures (plan parameter as keyword-only).
mkl_fft/_numpy_fft.py Updated Hermitian FFT implementations and adjusted imports to include _swap_direction.
mkl_fft/_fft_utils.py Added the _swap_direction helper to the module’s public API.
Files not reviewed (1)
  • CHANGES.rst: Language not supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant