Skip to content

Conversation

@mzweilin
Copy link
Contributor

What does this PR do?

This PR adds a recursive convertor mart.transforms.tensor_array.convert that converts between Numpy arrays and PyTorch tensors hidden in complex data structures.

This is useful when running MART attacks in ARMORY because the Numpy data structure is used in ARMORY.

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing

Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

  • pytest
  • CUDA_VISIBLE_DEVICES=0 python -m mart experiment=CIFAR10_CNN_Adv trainer=gpu trainer.precision=16 reports 70% (21 sec/epoch).
  • CUDA_VISIBLE_DEVICES=0,1 python -m mart experiment=CIFAR10_CNN_Adv trainer=ddp trainer.precision=16 trainer.devices=2 model.optimizer.lr=0.2 trainer.max_steps=2925 datamodule.ims_per_batch=256 datamodule.world_size=2 reports 70% (14 sec/epoch).

Before submitting

  • The title is self-explanatory and the description concisely explains the PR
  • My PR does only one thing, instead of bundling different changes together
  • I list all the breaking changes introduced by this pull request
  • I have commented my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have run pre-commit hooks with pre-commit run -a command without errors

Did you have fun?

Make sure you had fun coding 🙃

Copy link
Contributor

@dxoigmn dxoigmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you looked at torch's collate functionality? That can walk python data structure and apply a function. Might be helpful to reuse that here.

@dxoigmn
Copy link
Contributor

dxoigmn commented Sep 21, 2023

@mzweilin
Copy link
Contributor Author

mzweilin commented Sep 21, 2023

Have you looked at torch's collate functionality? That can walk python data structure and apply a function. Might be helpful to reuse that here.

torch.utils.data.default_convert() is closer to our convert(), but it is not designed to be extensible with internal if-else.

We are not collating data here, so I don't want to abuse default_collate() or collate().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants