Dev by robert-a-forsyth · Pull Request #161 · IntGenomicsLab/lrsomatic

robert-a-forsyth · 2026-04-28T12:47:13Z

PR checklist

ASCAT GC and RT LogR correct added to hg38, GC correct to T2T.

ASCAT pdf plots, minor channel fix

changelog

…ab/lrsomatic into deepvariant_opt_pon_changes

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…ab/lrsomatic into deepvariant_opt_pon_changes

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Deepvariant opt pon changes

Copilot

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

github-actions · 2026-04-28T12:49:39Z

`nf-core pipelines lint` overall result: Passed ✅ ⚠️

Posted for pipeline commit d92dd71

+| ✅ 208 tests passed       |+
#| ❔  21 tests were ignored |#
!| ❗  34 tests had warnings |!

Details

❗ Test warnings:

pipeline_todos - TODO string in README.md: Include a figure that guides the user through the major workflow steps. Many nf-core
pipeline_todos - TODO string in nextflow.config: Specify your pipeline's command line flags
pipeline_todos - TODO string in nextflow.config: Update the field with the details of the contributors to your pipeline. New with Nextflow version 24.10.0
pipeline_todos - TODO string in lint_log.txt: Named file extensions MUST be emitted for ALL output channels
pipeline_todos - TODO string in lint_log.txt: List additional required output channels/values here
pipeline_todos - TODO string in lint_log.txt: Named file extensions MUST be emitted for ALL output channels
pipeline_todos - TODO string in lint_log.txt: List additional required output channels/values here
pipeline_todos - TODO string in lint_log.txt: Named file extensions MUST be emitted for ALL output channels
pipeline_todos - TODO string in lint_log.txt: List additional required output channels/values here
pipeline_todos - TODO string in lint_log.txt: Named file extensions MUST be emitted for ALL output channels
pipeline_todos - TODO string in lint_log.txt: List additional required output channels/values here
pipeline_todos - TODO string in lint_log.txt: Named file extensions MUST be emitted for ALL output channels
pipeline_todos - TODO string in lint_log.txt: List additional required output channels/values here
pipeline_todos - TODO string in lint_log.txt: Named file extensions MUST be emitted for ALL output channels
pipeline_todos - TODO string in lint_log.txt: List additional required output channels/values here
pipeline_todos - TODO string in lint_log.txt: Named file extensions MUST be emitted for ALL output channels
pipeline_todos - TODO string in lint_log.txt: List additional required output channels/values here
pipeline_todos - TODO string in lint_log.txt: Named file extensions MUST be emitted for ALL output channels
pipeline_todos - TODO string in lint_log.txt: List additional required output channels/values here
pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
pipeline_todos - TODO string in nextflow.config: Specify any additional parameters here
pipeline_todos - TODO string in base.config: Check the defaults for all processes
pipeline_todos - TODO string in base.config: Customise requirements for specific processes.
pipeline_todos - TODO string in meta.yml: #Add a description of the module and list keywords
schema_description - No description provided in schema for parameter: autocorrelation
schema_description - No description provided in schema for parameter: vep_custom
schema_description - No description provided in schema for parameter: vep_custom_tbi
schema_description - No description provided in schema for parameter: severus_minsupport
schema_description - No description provided in schema for parameter: wakhan_chroms
local_component_structure - small_variant_consensus.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
local_component_structure - prepare_annotation.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
local_component_structure - deepsomatic.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
local_component_structure - phasing_haplotyping.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure
local_component_structure - prepare_reference_files.nf in subworkflows/local should be moved to a SUBWORKFLOW_NAME/main.nf structure

❔ Tests ignored:

files_exist - File is ignored: CODE_OF_CONDUCT.md
files_exist - File is ignored: assets/nf-core-lrsomatic_logo_light.png
files_exist - File is ignored: docs/images/nf-core-lrsomatic_logo_light.png
files_exist - File is ignored: docs/images/nf-core-lrsomatic_logo_dark.png
files_exist - File is ignored: .github/ISSUE_TEMPLATE/config.yml
files_exist - File is ignored: .github/workflows/awstest.yml
files_exist - File is ignored: .github/workflows/awsfulltest.yml
nextflow_config - Config variable ignored: manifest.name
nextflow_config - Config variable ignored: manifest.homePage
files_unchanged - File ignored due to lint config: CODE_OF_CONDUCT.md
files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
files_unchanged - File does not exist: .github/ISSUE_TEMPLATE/config.yml
files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
files_unchanged - File ignored due to lint config: assets/email_template.txt
files_unchanged - File ignored due to lint config: assets/nf-core-lrsomatic_logo_light.png
files_unchanged - File ignored due to lint config: docs/images/nf-core-lrsomatic_logo_light.png
files_unchanged - File ignored due to lint config: docs/images/nf-core-lrsomatic_logo_dark.png
files_unchanged - File ignored due to lint config: docs/README.md
actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/lrsomatic/lrsomatic/.github/workflows/awstest.yml
schema_params - schema_params

✅ Tests passed:

files_exist - File found: .gitattributes
files_exist - File found: .gitignore
files_exist - File found: .nf-core.yml
files_exist - File found: .prettierignore
files_exist - File found: .prettierrc.yml
files_exist - File found: CHANGELOG.md
files_exist - File found: CITATIONS.md
files_exist - File found: LICENSE or LICENSE.md or LICENCE or LICENCE.md
files_exist - File found: nextflow_schema.json
files_exist - File found: nextflow.config
files_exist - File found: README.md
files_exist - File found: .github/.dockstore.yml
files_exist - File found: .github/CONTRIBUTING.md
files_exist - File found: .github/ISSUE_TEMPLATE/bug_report.yml
files_exist - File found: .github/ISSUE_TEMPLATE/feature_request.yml
files_exist - File found: .github/PULL_REQUEST_TEMPLATE.md
files_exist - File found: .github/workflows/branch.yml
files_exist - File found: .github/workflows/nf-test.yml
files_exist - File found: .github/actions/get-shards/action.yml
files_exist - File found: .github/actions/nf-test/action.yml
files_exist - File found: .github/workflows/linting_comment.yml
files_exist - File found: .github/workflows/linting.yml
files_exist - File found: assets/email_template.html
files_exist - File found: assets/email_template.txt
files_exist - File found: assets/sendmail_template.txt
files_exist - File found: conf/modules.config
files_exist - File found: conf/test.config
files_exist - File found: conf/test_full.config
files_exist - File found: docs/output.md
files_exist - File found: docs/README.md
files_exist - File found: docs/README.md
files_exist - File found: docs/usage.md
files_exist - File found: nf-test.config
files_exist - File found: tests/default.nf.test
files_exist - File found: main.nf
files_exist - File found: assets/multiqc_config.yml
files_exist - File found: conf/base.config
files_exist - File found: conf/igenomes.config
files_exist - File found: conf/igenomes_ignored.config
files_exist - File found: modules.json
files_exist - File found: ro-crate-metadata.json
files_exist - File not found check: .github/ISSUE_TEMPLATE/bug_report.md
files_exist - File not found check: .github/ISSUE_TEMPLATE/feature_request.md
files_exist - File not found check: .github/workflows/push_dockerhub.yml
files_exist - File not found check: .markdownlint.yml
files_exist - File not found check: .nf-core.yaml
files_exist - File not found check: .yamllint.yml
files_exist - File not found check: bin/markdown_to_html.r
files_exist - File not found check: conf/aws.config
files_exist - File not found check: docs/images/nf-core-lrsomatic_logo.png
files_exist - File not found check: lib/Checks.groovy
files_exist - File not found check: lib/Completion.groovy
files_exist - File not found check: lib/NfcoreTemplate.groovy
files_exist - File not found check: lib/Utils.groovy
files_exist - File not found check: lib/Workflow.groovy
files_exist - File not found check: lib/WorkflowMain.groovy
files_exist - File not found check: lib/WorkflowLrsomatic.groovy
files_exist - File not found check: parameters.settings.json
files_exist - File not found check: pipeline_template.yml
files_exist - File not found check: Singularity
files_exist - File not found check: lib/nfcore_external_java_deps.jar
files_exist - File not found check: .travis.yml
nextflow_config - Found nf-schema plugin
nextflow_config - Config variable found: manifest.nextflowVersion
nextflow_config - Config variable found: manifest.description
nextflow_config - Config variable found: manifest.version
nextflow_config - Config variable found: timeline.enabled
nextflow_config - Config variable found: trace.enabled
nextflow_config - Config variable found: report.enabled
nextflow_config - Config variable found: dag.enabled
nextflow_config - Config variable found: process.cpus
nextflow_config - Config variable found: process.memory
nextflow_config - Config variable found: process.time
nextflow_config - Config variable found: params.outdir
nextflow_config - Config variable found: params.input
nextflow_config - Config variable found: manifest.mainScript
nextflow_config - Config variable found: timeline.file
nextflow_config - Config variable found: trace.file
nextflow_config - Config variable found: report.file
nextflow_config - Config variable found: dag.file
nextflow_config - Config variable (correctly) not found: params.nf_required_version
nextflow_config - Config variable (correctly) not found: params.container
nextflow_config - Config variable (correctly) not found: params.singleEnd
nextflow_config - Config variable (correctly) not found: params.igenomesIgnore
nextflow_config - Config variable (correctly) not found: params.name
nextflow_config - Config variable (correctly) not found: params.enable_conda
nextflow_config - Config variable (correctly) not found: params.max_cpus
nextflow_config - Config variable (correctly) not found: params.max_memory
nextflow_config - Config variable (correctly) not found: params.max_time
nextflow_config - Config variable (correctly) not found: params.validationFailUnrecognisedParams
nextflow_config - Config variable (correctly) not found: params.validationLenientMode
nextflow_config - Config variable (correctly) not found: params.validationSchemaIgnoreParams
nextflow_config - Config variable (correctly) not found: params.validationShowHiddenParams
nextflow_config - Config variable (correctly) not found: validation.failUnrecognisedParams
nextflow_config - Config variable (correctly) not found: validation.failUnrecognisedHeaders
nextflow_config - Config timeline.enabled had correct value: true
nextflow_config - Config report.enabled had correct value: true
nextflow_config - Config trace.enabled had correct value: true
nextflow_config - Config dag.enabled had correct value: true
nextflow_config - Config dag.file ended with .html
nextflow_config - Config variable manifest.nextflowVersion started with >= or !>=
nextflow_config - Config manifest.version ends in dev: 1.1.0dev
nextflow_config - Config params.custom_config_version is set to master
nextflow_config - Config params.custom_config_base is set to https://raw.githubusercontent.com/nf-core/configs/master
nextflow_config - Lines for loading custom profiles found
nextflow_config - nextflow.config contains configuration profile test
nextflow_config - Config default value correct: params.germline_var_combine= all
nextflow_config - Config default value correct: params.somatic_var_combine= all
nextflow_config - Config default value correct: params.prioritize_caller_germline= deepvariant
nextflow_config - Config default value correct: params.prioritize_caller_somatic= deepsomatic
nextflow_config - Config default value correct: params.igenomes_ignore= false
nextflow_config - Config default value correct: params.igenomes_base= s3://ngi-igenomes/igenomes/
nextflow_config - Config default value correct: params.save_secondary_alignment= true
nextflow_config - Config default value correct: params.vep_cache= s3://annotation-cache/vep_cache/
nextflow_config - Config default value correct: params.vep_args= --everything --filter_common --per_gene --total_length --offline --format vcf
nextflow_config - Config default value correct: params.vep_cache_version= 113
nextflow_config - Config default value correct: params.download_vep_cache= false
nextflow_config - Config default value correct: params.severus_minsupport= 3
nextflow_config - Config default value correct: params.ascat_penalty= 150
nextflow_config - Config default value correct: params.ascat_min_base_qual= 20
nextflow_config - Config default value correct: params.ascat_min_counts= 10
nextflow_config - Config default value correct: params.ascat_min_map_qual= 10
nextflow_config - Config default value correct: params.ascat_longread_bins= 2000
nextflow_config - Config default value correct: params.ascat_allelecounter_flags= -f 0
nextflow_config - Config default value correct: params.ascat_pdf_plots= false
nextflow_config - Config default value correct: params.skip_qc= false
nextflow_config - Config default value correct: params.skip_cramino= false
nextflow_config - Config default value correct: params.skip_mosdepth= false
nextflow_config - Config default value correct: params.skip_bamstats= false
nextflow_config - Config default value correct: params.skip_wakhan= false
nextflow_config - Config default value correct: params.skip_fiber= false
nextflow_config - Config default value correct: params.skip_ascat= false
nextflow_config - Config default value correct: params.skip_m6a= false
nextflow_config - Config default value correct: params.skip_vep= false
nextflow_config - Config default value correct: params.skip_normalfiber= false
nextflow_config - Config default value correct: params.skip_nanoplot= false
nextflow_config - Config default value correct: params.skip_whatshapstats= false
nextflow_config - Config default value correct: params.skip_modcall= false
nextflow_config - Config default value correct: params.use_gpu= false
nextflow_config - Config default value correct: params.custom_config_version= master
nextflow_config - Config default value correct: params.custom_config_base= https://raw.githubusercontent.com/nf-core/configs/master
nextflow_config - Config default value correct: params.version= false
nextflow_config - Config default value correct: params.publish_dir_mode= copy
nextflow_config - Config default value correct: params.plaintext_email= false
nextflow_config - Config default value correct: params.max_multiqc_email_size= 25.MB
nextflow_config - Config default value correct: params.monochrome_logs= false
nextflow_config - Config default value correct: params.validate_params= true
nextflow_config - Config default value correct: params.pipelines_testdata_base_path= https://raw.githubusercontent.com/nf-core/test-datasets/
nextflow_config - Config default value correct: params.help= false
nextflow_config - Config default value correct: params.help_full= false
nextflow_config - Config default value correct: params.show_hidden= false
nf_test_content - 'tests/default.nf.test' contains outdir parameter
nf_test_content - 'tests/default.nf.test' snapshots a 'versions.yml' file
nf_test_content - 'tests/default.nf.test' snapshots a 'versions.yml' file
nf_test_content - 'tests/nextflow.config' contains modules_testdata_base_path
nf_test_content - 'tests/nextflow.config' contains pipelines_testdata_base_path
nf_test_content - 'nf-test.config' sets a testsDir
nf_test_content - 'nf-test.config' sets a workDir
nf_test_content - 'nf-test.config' sets a configFile
files_unchanged - .gitattributes matches the template
files_unchanged - .prettierrc.yml matches the template
files_unchanged - LICENSE matches the template
files_unchanged - .github/.dockstore.yml matches the template
files_unchanged - .github/ISSUE_TEMPLATE/feature_request.yml matches the template
files_unchanged - .github/workflows/branch.yml matches the template
files_unchanged - .github/workflows/linting_comment.yml matches the template
files_unchanged - .github/workflows/linting.yml matches the template
files_unchanged - assets/email_template.html matches the template
files_unchanged - assets/sendmail_template.txt matches the template
files_unchanged - .gitignore matches the template
files_unchanged - .prettierignore matches the template
actions_nf_test - '.github/workflows/nf-test.yml' is triggered on expected events
actions_nf_test - '.github/workflows/nf-test.yml' checks minimum NF version
readme - README Nextflow minimum version badge matched config. Badge: 25.04.0, Config: 25.04.0
readme - README nf-core template version badge found.
readme - README Zenodo placeholder was replaced with DOI.
pipeline_if_empty_null - No ifEmpty(null) strings found
plugin_includes - No wrong validation plugin imports have been found
pipeline_name_conventions - Name adheres to nf-core convention
template_strings - Did not find any Jinja template strings (0 files)
schema_lint - Schema lint passed
schema_lint - Schema title + description lint passed
schema_lint - Input mimetype lint passed: 'text/csv'
system_exit - No System.exit calls found
actions_schema_validation - Workflow validation passed: clean-up.yml
actions_schema_validation - Workflow validation passed: download_pipeline.yml
actions_schema_validation - Workflow validation passed: linting_comment.yml
actions_schema_validation - Workflow validation passed: fix_linting.yml
actions_schema_validation - Workflow validation passed: nf-test.yml
actions_schema_validation - Workflow validation passed: branch.yml
actions_schema_validation - Workflow validation passed: linting.yml
actions_schema_validation - Workflow validation passed: template-version-comment.yml
merge_markers - No merge markers found in pipeline files
modules_json - Only installed modules found in modules.json
multiqc_config - assets/multiqc_config.yml found and not ignored.
multiqc_config - assets/multiqc_config.yml contains report_section_order
multiqc_config - assets/multiqc_config.yml contains export_plots
multiqc_config - assets/multiqc_config.yml contains report_comment
multiqc_config - assets/multiqc_config.yml follows the ordering scheme of the minimally required plugins.
multiqc_config - assets/multiqc_config.yml contains 'export_plots: true'.
modules_structure - modules directory structure is correct 'modules/nf-core/TOOL/SUBTOOL'
local_component_structure - local modules directory structure is correct 'modules/local/TOOL/SUBTOOL'
base_config - conf/base.config found and not ignored.
modules_config - conf/modules.config found and not ignored.
modules_config - ENSEMBLVEP_DOWNLOAD found in conf/modules.config and Nextflow scripts.
nfcore_yml - Repository type in .nf-core.yml is valid: pipeline
nfcore_yml - nf-core version in .nf-core.yml is set to the latest version: 3.5.2
rocrate_readme_sync - RO-Crate descriptions are in sync with README.md.

Run details

nf-core/tools version 3.5.2
Run at 2026-04-28 12:49:22

AmberVerhasselt and others added 30 commits December 22, 2025 10:31

changed GC file link T2T to correct one 2.0

2c9e2e6

fix GC file ASCAT 3.0

b567356

Fix case of ascat_pdf_plots value to 'FALSE'

af58b03

Merge pull request #116 from AmberVerhasselt/dev

9eda20b

ASCAT GC and RT LogR correct added to hg38, GC correct to T2T.

Merge pull request #117 from IntGenomicsLab/hotfix

01ba648

ASCAT pdf plots, minor channel fix

Template update for nf-core/tools version 3.5.1

dcc9e4a

template merge

e637341

change versioning output to topic for all local modules

e003997

pre-commit

d777e58

mass updates of nf-core modules and subworkflows

cf01c78

minor changelog update

b01cd5e

Changes to use topic versions where possible

64b76b8

linting

4774868

fixes in longphase phase after updating nf-core module

86997ac

linting

abb0c68

added vep .diff file

97021f1

update samtools stats

38b9dcc

update nf-core subworkflows

e0b0b04

update ascat

54a5207

our own ascat version with new diff file

0b57918

now actually our ascat version

b9fea8a

prettier

b02fb99

recreate diff file vep

03acaca

Channel. --> channel. changes

7be5248

bunch of tiny fixes

b72a135

linting

00a7cdc

revert capital C

19c8a09

update snap

f369ffe

update local modules version where applicable

e6ebb34

force "." prefix for severus

60fd6c5

ljwharbers and others added 27 commits April 10, 2026 13:35

linting

03cabaa

Merge pull request #158 from IntGenomicsLab/changelog

d74e13b

changelog

deepvariant optimization

7110a65

fix pon

99d6102

some final clean ups

5c48469

final fixes

3632096

fix out

235a437

final updates

31067b1

bcftools sort as precaution

aee7f7b

fix sort

aabb418

fix replicate merging

9c0e29b

remove claude and re-enabled copilot in settings for PR code review

bf8fa56

snap update + strict syntax

9e3acc8

minor changes

6405703

linting

afa63b0

Merge branch 'deepvariant_opt_pon_changes' of github.com:IntGenomicsL…

4aa1992

…ab/lrsomatic into deepvariant_opt_pon_changes

Update subworkflows/local/small_variant_consensus.nf

1efbd33

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix linting

ab02321

Merge branch 'deepvariant_opt_pon_changes' of github.com:IntGenomicsL…

34ac711

…ab/lrsomatic into deepvariant_opt_pon_changes

prettier

13ecb5e

regenerate patch

c7d7862

prettier

06f361b

Update docs/usage.md

07dddae

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

why copilot mess up my linting

9caa86b

snap

3df1e18

switch label

d933cb2

Merge pull request #160 from IntGenomicsLab/deepvariant_opt_pon_changes

d92dd71

Deepvariant opt pon changes

Copilot AI review requested due to automatic review settings April 28, 2026 12:47

Copilot AI reviewed Apr 28, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dev#161

Dev#161
robert-a-forsyth wants to merge 269 commits into
mainfrom
dev

robert-a-forsyth commented Apr 28, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions Bot commented Apr 28, 2026 •

edited

Loading

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

robert-a-forsyth commented Apr 28, 2026

PR checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

nf-core pipelines lint overall result: Passed ✅ ⚠️

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

github-actions Bot commented Apr 28, 2026 •

edited

Loading

`nf-core pipelines lint` overall result: Passed ✅ ⚠️